-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(azure-iot-device): security provider should deal with module SAS #703
Conversation
/az run node-canary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -79,9 +79,12 @@ export class SharedAccessSignatureAuthenticationProvider extends EventEmitter im | |||
const sas: SharedAccessSignature = SharedAccessSignature.parse(sharedAccessSignature); | |||
const decodedUri = decodeURIComponent(sas.sr); | |||
const uriSegments = decodedUri.split('/'); | |||
const uriDeviceId = (uriSegments.length >= 2 && uriSegments[1] === 'devices') ? (uriSegments[2]) : null; | |||
const uriModuleId = (uriSegments.length >= 4 && uriSegments[3] === 'modules') ? (uriSegments[4]) : null; | |||
const credentials: TransportConfig = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test please.
8303928
to
d2c272a
Compare
/az run horton-node-gate |
The SAS security provider should propagate through the moduleId if the SAS has one.
d2c272a
to
56113c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SAS security provider should propagate through the moduleId if the SAS has one.
#657