Updated file upload sample to reflect current SDK changes. #834

solidprinciples · 2020-07-02T06:10:28Z

Checklist

I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-node/blob/master/.github/CONTRIBUTING.md).
I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
- There are no tests for covering samples, so this is not applicable.
If this is a modification that impacts the behavior of a public API
- I edited the corresponding document in the devdoc folder and added or modified requirements.

Reference/Link to the issue solved with this PR (if any)

No current issue was being tracked - the current SDK does not contain StorageURL, etc.

Description of the problem

Upload file sample does not work with the current-most SDKs.

Description of the solution

Updated the upload file sample code to reflect current most SDK changes.

YoDaMa · 2020-07-02T17:06:24Z

/azp run all

azure-pipelines · 2020-07-02T17:06:29Z

No pipelines are associated with this pull request.

YoDaMa · 2020-07-02T17:06:47Z

cheers for the PR @solidprinciples

anthonyvercolano · 2020-07-03T00:38:51Z

/azp run

azure-pipelines · 2020-07-03T00:39:05Z

Azure Pipelines successfully started running 2 pipeline(s).

…-sdk-node

solidprinciples · 2020-07-03T06:47:55Z

/azp run

azure-pipelines · 2020-07-03T06:48:00Z

Commenter does not have sufficient privileges for PR 834 in repo Azure/azure-iot-sdk-node

anthonyvercolano · 2020-07-03T22:54:24Z

/azp run all

azure-pipelines · 2020-07-03T22:54:29Z

No pipelines are associated with this pull request.

anthonyvercolano · 2020-07-03T22:57:23Z

/azp run

azure-pipelines · 2020-07-03T22:57:39Z

Azure Pipelines successfully started running 2 pipeline(s).

anthonyvercolano · 2020-07-07T20:02:36Z

@solidprinciples I'm going to let @YoDaMa be the judge on this PR, but, would you be able to fix the linting error?

> iot-device-samples@0.0.1 lint /home/vsts/work/1/s/device/samples
> jshint --show-non-errors .

upload_to_blob_advanced.js: line 87, col 21, Missing semicolon.

And push?

anthonyvercolano · 2020-07-10T17:16:01Z

/azp run

azure-pipelines · 2020-07-10T17:16:16Z

Azure Pipelines successfully started running 2 pipeline(s).

YoDaMa · 2020-07-10T18:59:16Z

/azp run

azure-pipelines · 2020-07-10T18:59:31Z

Azure Pipelines successfully started running 2 pipeline(s).

YoDaMa

there are some error handling fixes in the new api that need to be incorporated.

YoDaMa · 2020-07-10T20:02:53Z

/azp run

azure-pipelines · 2020-07-10T20:03:07Z

Azure Pipelines successfully started running 2 pipeline(s).

YoDaMa · 2020-07-10T20:29:18Z

/azp run

azure-pipelines · 2020-07-10T20:29:32Z

Azure Pipelines successfully started running 2 pipeline(s).

YoDaMa · 2020-07-10T20:41:29Z

/azp run node-canary

azure-pipelines · 2020-07-10T20:41:37Z

Azure Pipelines successfully started running 1 pipeline(s).

YoDaMa · 2020-07-13T16:41:27Z

/azp run node-canary

azure-pipelines · 2020-07-13T16:41:35Z

Azure Pipelines successfully started running 1 pipeline(s).

* fix(azure-iothub): fix signatue for getTwin, updateTwin, updateModuleTwin to use Twin fix #673 * improvement(provisioning samples): use the results of the registration to create and open device * test(azure-iot-device-mqtt): reformat _mqtt_test.js (#741) * (chore) add issue templates workflow * Delete ISSUE_TEMPLATE.md * Update bug-report.md * fix(azure-iot-mqtt-base): forceReconnect for disconnecting hang in mqtt-base (#770) * release(2020-04-24): bump package versions (#771) Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> * refactor: update to mqtt.js v4 (#772) * build: update to mqtt.js v4 * refactor: add debug logs * fix: eslint issue * chore: remove network_e2e directory - no longer used (#775) * refactor: expose connection error in mqtt (#776) * release(2020-05-07): bump package versions (#788) * release(2020-05-07): bump package versions Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> * refactor(multipe packages): c2d states no longer using booleans (#797) This moves the logic of checking if C2D is enabled down to the transport level, since it is not necessarily accurate to represent it at the device client level. There is not enough information at that level to make totally accurate judgements of if it is connected or not. * chore(azure-iot-device-amqp): debug logs for c2d (#804) * build: update to mqtt.js v4 * chore: add debug logs * chore(azure-iot-device): updating api version to support twin arrays (#806) * improvement(azure-iot-mqtt-base): maintain knowledge of on the wire publishes (#808) By tracking the on the wire publishes we can reliably complete in case of disconnects or other errors. * feat(azure-iot-mqtt-device): modelID option (#809) This adds the setOption for ModelID, which will enable users to use the existing device client library as a PnP library. To accomodate the lack of support in the existing service API, a switching API call has been added that will use the preview API version if the modelID is set. * release(2020-05-28): bump package versions (#810) Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> * Create synctodevops.yml * chore(azure-iot-provisioning-device): update samples to use env var (#816) * Add CodeQL security scanning (#815) Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com> * improvement(azure-iot-mqtt-base): add timeouts to publishes that have… (#818) * improvement(azure-iot-mqtt-base): add timeouts to publishes that have not been PUBACKed by the service 744 * update classes and unique identifiers. * chore: create config.yml for issue templates (#823) * chore: create config.yml for issue templates * chore: update technical question for msft q&a * fix: add vanity link for IoT help * chore: update technical question options * fix: add https:// * fix: add https:// * fix: add https:// * fix: add https:// Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com> * feat(azure-iot-device): adds emit to connect (#819) 'connect' is emitted whenever the device transport FSM enters the "connected" state for MQTT, and "authenticated" for AMQP. * fix(azure-iot-device): lint error on simple sample (#826) * fix(azure-iot-device): lint error on simple sample * fix(azure-iot-device): add sample linting to the CI * refactor(multiple): update to typescript 3.7.5 move to dist instead of lib parameter checking and suppression (#824) * chore: updating docs to clarify edge support for linux only * refactor(multiple): update to typescript 3.7.5 move to dist etc (#830) * chore: node pnp sample for summer * chore: update prov sample to use env variables (#831) * chore: node pnp sample for summer * refactor(multiple): update to typescript 3.7.5 move to dist vs lib other minor (#833) * chore: node pnp sample for summer * chore: rename digital-twin-model-id to model-id in mqtt (#829) * chore: node pnp sample for summer * chore: node pnp sample for summer * chore: initial addition of pnp simple thermostat sample (#827) * chore: node pnp sample for summer * release(2020-07-06): bump package versions (#838) Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> * chore: fixing the sample for feedback (#839) * chore: remove writable property in reported (#842) * chore: some changes * chore: some changes * chore: some changes * Update pnpTemperatureController.js * Updated file upload sample to reflect current SDK changes. (#834) * fix(sample): update sample to use current SDK changes * fix(sample): update to use latest SDK changes, add use strict * fix(sample): update sample to use current SDK changes, fix linting issue * Update upload_to_blob_advanced.js * Update upload_to_blob_advanced.js Co-authored-by: Chandler Lattin <chlattin@microsoft.com> Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@microsoft.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@gmail.com> * chore: align environment variable names * Update pnpTemperatureController.js * chore: removing all the lib folders in repo Co-authored-by: Anthony Ercolano <toercola@microsoft.com> Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@microsoft.com> Co-authored-by: Elena Horton <52430760+elhorton@users.noreply.github.com> Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com> Co-authored-by: olivakar <oliva.kar@microsoft.com> Co-authored-by: olivakar <oliva.tanusree@gmail.com> Co-authored-by: Chandler Lattin <chandlerlattin@knights.ucf.edu> Co-authored-by: Chandler Lattin <chlattin@microsoft.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@gmail.com>

* fix(azure-iothub): fix signatue for getTwin, updateTwin, updateModuleTwin to use Twin fix #673 * improvement(provisioning samples): use the results of the registration to create and open device * test(azure-iot-device-mqtt): reformat _mqtt_test.js (#741) * (chore) add issue templates workflow * Delete ISSUE_TEMPLATE.md * Update bug-report.md * fix(azure-iot-mqtt-base): forceReconnect for disconnecting hang in mqtt-base (#770) * release(2020-04-24): bump package versions (#771) Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> * refactor: update to mqtt.js v4 (#772) * build: update to mqtt.js v4 * refactor: add debug logs * fix: eslint issue * chore: remove network_e2e directory - no longer used (#775) * refactor: expose connection error in mqtt (#776) * release(2020-05-07): bump package versions (#788) * release(2020-05-07): bump package versions Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> * refactor(multipe packages): c2d states no longer using booleans (#797) This moves the logic of checking if C2D is enabled down to the transport level, since it is not necessarily accurate to represent it at the device client level. There is not enough information at that level to make totally accurate judgements of if it is connected or not. * chore(azure-iot-device-amqp): debug logs for c2d (#804) * build: update to mqtt.js v4 * chore: add debug logs * chore(azure-iot-device): updating api version to support twin arrays (#806) * improvement(azure-iot-mqtt-base): maintain knowledge of on the wire publishes (#808) By tracking the on the wire publishes we can reliably complete in case of disconnects or other errors. * feat(azure-iot-mqtt-device): modelID option (#809) This adds the setOption for ModelID, which will enable users to use the existing device client library as a PnP library. To accomodate the lack of support in the existing service API, a switching API call has been added that will use the preview API version if the modelID is set. * release(2020-05-28): bump package versions (#810) Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> * Create synctodevops.yml * chore(azure-iot-provisioning-device): update samples to use env var (#816) * Add CodeQL security scanning (#815) Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com> * improvement(azure-iot-mqtt-base): add timeouts to publishes that have… (#818) * improvement(azure-iot-mqtt-base): add timeouts to publishes that have not been PUBACKed by the service 744 * update classes and unique identifiers. * chore: create config.yml for issue templates (#823) * chore: create config.yml for issue templates * chore: update technical question for msft q&a * fix: add vanity link for IoT help * chore: update technical question options * fix: add https:// * fix: add https:// * fix: add https:// * fix: add https:// Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com> * feat(azure-iot-device): adds emit to connect (#819) 'connect' is emitted whenever the device transport FSM enters the "connected" state for MQTT, and "authenticated" for AMQP. * fix(azure-iot-device): lint error on simple sample (#826) * fix(azure-iot-device): lint error on simple sample * fix(azure-iot-device): add sample linting to the CI * refactor(multiple): update to typescript 3.7.5 move to dist instead of lib parameter checking and suppression (#824) * chore: updating docs to clarify edge support for linux only * refactor(multiple): update to typescript 3.7.5 move to dist etc (#830) * chore: node pnp sample for summer * chore: update prov sample to use env variables (#831) * chore: node pnp sample for summer * refactor(multiple): update to typescript 3.7.5 move to dist vs lib other minor (#833) * chore: node pnp sample for summer * chore: rename digital-twin-model-id to model-id in mqtt (#829) * chore: node pnp sample for summer * chore: node pnp sample for summer * chore: initial addition of pnp simple thermostat sample (#827) * chore: node pnp sample for summer * release(2020-07-06): bump package versions (#838) Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> * chore: fixing the sample for feedback (#839) * chore: remove writable property in reported (#842) * chore: some changes * chore: some changes * chore: some changes * Update pnpTemperatureController.js * Updated file upload sample to reflect current SDK changes. (#834) * fix(sample): update sample to use current SDK changes * fix(sample): update to use latest SDK changes, add use strict * fix(sample): update sample to use current SDK changes, fix linting issue * Update upload_to_blob_advanced.js * Update upload_to_blob_advanced.js Co-authored-by: Chandler Lattin <chlattin@microsoft.com> Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@microsoft.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@gmail.com> * chore: align environment variable names * Update pnpTemperatureController.js * chore: removing all the lib folders in repo * chore: removing a few more lib folders * chore: updating twin calls to the pnp api-version * chore: adding modelId object to twin * chore: fixing registry sample * fix(azure-iothub): update vesion and support modelId service side Updated to -pnp-refresh.4. Fixed the sample to print out the modelId. Updated various dependents to the latest branch. Co-authored-by: Yoseph Maguire <yoseph.maguire@microsoft.com> Co-authored-by: Elena Horton <52430760+elhorton@users.noreply.github.com> Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com> Co-authored-by: Jelani Brandon <jelani.brandon@microsoft.com> Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com> Co-authored-by: olivakar <oliva.kar@microsoft.com> Co-authored-by: olivakar <oliva.tanusree@gmail.com> Co-authored-by: Chandler Lattin <chandlerlattin@knights.ucf.edu> Co-authored-by: Chandler Lattin <chlattin@microsoft.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@gmail.com> Co-authored-by: Jelani Brandon <jelanibrandon@gmail.com>

fix(sample): update sample to use current SDK changes

bab7fab

Merge branch 'master' into master

a55e359

Chandler Lattin added 2 commits July 2, 2020 23:46

fix(sample): update to use latest SDK changes, add use strict

50a2300

Merge branch 'master' of https://github.com/solidprinciples/azure-iot…

f4a9f62

…-sdk-node

fix(sample): update sample to use current SDK changes, fix linting issue

727bd06

Merge branch 'master' into master

bba6fd0

YoDaMa approved these changes Jul 10, 2020

View reviewed changes

YoDaMa suggested changes Jul 10, 2020

View reviewed changes

Update upload_to_blob_advanced.js

5bed7f6

YoDaMa approved these changes Jul 10, 2020

View reviewed changes

Update upload_to_blob_advanced.js

90d3ade

anthonyvercolano merged commit 33046fb into Azure:master Jul 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated file upload sample to reflect current SDK changes. #834

Updated file upload sample to reflect current SDK changes. #834

solidprinciples commented Jul 2, 2020 •

edited

Loading

YoDaMa commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

YoDaMa commented Jul 2, 2020

anthonyvercolano commented Jul 3, 2020

azure-pipelines bot commented Jul 3, 2020

solidprinciples commented Jul 3, 2020

azure-pipelines bot commented Jul 3, 2020

anthonyvercolano commented Jul 3, 2020

azure-pipelines bot commented Jul 3, 2020

anthonyvercolano commented Jul 3, 2020

azure-pipelines bot commented Jul 3, 2020

anthonyvercolano commented Jul 7, 2020

anthonyvercolano commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa left a comment

YoDaMa commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

Updated file upload sample to reflect current SDK changes. #834

Updated file upload sample to reflect current SDK changes. #834

Conversation

solidprinciples commented Jul 2, 2020 • edited Loading

Checklist

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

YoDaMa commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

YoDaMa commented Jul 2, 2020

anthonyvercolano commented Jul 3, 2020

azure-pipelines bot commented Jul 3, 2020

solidprinciples commented Jul 3, 2020

azure-pipelines bot commented Jul 3, 2020

anthonyvercolano commented Jul 3, 2020

azure-pipelines bot commented Jul 3, 2020

anthonyvercolano commented Jul 3, 2020

azure-pipelines bot commented Jul 3, 2020

anthonyvercolano commented Jul 7, 2020

anthonyvercolano commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa left a comment

Choose a reason for hiding this comment

YoDaMa commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

YoDaMa commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

solidprinciples commented Jul 2, 2020 •

edited

Loading