-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updating pnp-preview-refresh to master branch #853
Merged
jebrando
merged 58 commits into
Azure:pnp-preview-refresh
from
jebrando:pnp-preview-refresh
Jul 20, 2020
Merged
chore: updating pnp-preview-refresh to master branch #853
jebrando
merged 58 commits into
Azure:pnp-preview-refresh
from
jebrando:pnp-preview-refresh
Jul 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Twin to use Twin fix #673
fix(azure-iothub): fix signature for getTwin, updateTwin, updateModule…
…n to create and open device
Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com>
* build: update to mqtt.js v4 * refactor: add debug logs * fix: eslint issue
* release(2020-05-07): bump package versions Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com>
This moves the logic of checking if C2D is enabled down to the transport level, since it is not necessarily accurate to represent it at the device client level. There is not enough information at that level to make totally accurate judgements of if it is connected or not.
* build: update to mqtt.js v4 * chore: add debug logs
…ublishes (#808) By tracking the on the wire publishes we can reliably complete in case of disconnects or other errors.
This adds the setOption for ModelID, which will enable users to use the existing device client library as a PnP library. To accomodate the lack of support in the existing service API, a switching API call has been added that will use the preview API version if the modelID is set.
Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com>
Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com>
#818) * improvement(azure-iot-mqtt-base): add timeouts to publishes that have not been PUBACKed by the service 744 * update classes and unique identifiers.
* chore: create config.yml for issue templates * chore: update technical question for msft q&a * fix: add vanity link for IoT help * chore: update technical question options * fix: add https:// * fix: add https:// * fix: add https:// * fix: add https:// Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com>
'connect' is emitted whenever the device transport FSM enters the "connected" state for MQTT, and "authenticated" for AMQP.
* fix(azure-iot-device): lint error on simple sample * fix(azure-iot-device): add sample linting to the CI
…f lib parameter checking and suppression (#824)
…ot-sdk-node into ok-pnp-summer-2
chore: node pnp sample for summer
Co-authored-by: Azure IoT Client Build <aziotclb@microsoft.com>
chore(azure-iot-device) : update the handler for twin
* fix(sample): update sample to use current SDK changes * fix(sample): update to use latest SDK changes, add use strict * fix(sample): update sample to use current SDK changes, fix linting issue * Update upload_to_blob_advanced.js * Update upload_to_blob_advanced.js Co-authored-by: Chandler Lattin <chlattin@microsoft.com> Co-authored-by: Anthony V. Ercolano <anthonyvercolano@users.noreply.github.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@microsoft.com> Co-authored-by: Yoseph Maguire <yoseph.maguire@gmail.com>
anthonyvercolano
requested changes
Jul 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
Can't take this one in. It picked up the lib/* directory. Somehow the .gitignore didn't get updated? |
anthonyvercolano
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devdoc
folder and added or modified requirements.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Description of the solution