Download proton as zip #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cd /tmp | ||
| curl -L $proton_repo/archive/$proton_branch.zip -o proton.zip | ||
| mkdir proton | ||
| unzip proton.zip -d proton |
There was a problem hiding this comment.
This script handles the general case, and it's a convenience for users--it's not a required step to build the project. I don't see a strong reason for changing git to unzip here. In specialized scenarios the script can be customized; changes wouldn't have to be contributed back.
There was a problem hiding this comment.
I explained my reasoning for this proposed change: it still handles the same general case, but does it faster with less overhead. Obviously it's up to you to ignore it.
|
Manually merged to develop. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At resin.io we build apps in the cloud. For me the git clone step has been hanging several times, and was really slow overall. Also it feels like it's a significant overhead to fetch the repo with all embedded info, as well as the git itself is big compared to unzip.
So I've updated the script to fetch the same sources (but without the extra git history and everything) as a ZIP.
I've also noticed that proton doesn't build without Java so I've added the JRE dependency.
// original PR https://github.com/Azure/azure-iot-suite-sdks/pull/59