Add constructor taking tenant id as parameter for AzureCredentials constructor when using MSI #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
michaelelleby
changed the title
loarabia
added
Authorization
customer-reported
yaohaizh
suggested changes
Jul 4, 2019
| @@ -81,6 +81,12 @@ public AzureCredentials(MSILoginInformation msiLoginInformation, AzureEnvironmen | |||
| this.msiTokenProviderFactory = new MSITokenProviderFactory(msiLoginInformation); | |||
| } | |||
|
|
|||
| public AzureCredentials(MSILoginInformation msiLoginInformation, string tenantId, AzureEnvironment environment) | |||
There was a problem hiding this comment.
If the tenantId is required, please change the above constructor directly, but not provide another one.
There was a problem hiding this comment.
Make the teantId as optional parameter as the last one and default value to null would be better, but not provide another API. Thanks.
yaohaizh
suggested changes
Jul 9, 2019
| @@ -81,6 +81,12 @@ public AzureCredentials(MSILoginInformation msiLoginInformation, AzureEnvironmen | |||
| this.msiTokenProviderFactory = new MSITokenProviderFactory(msiLoginInformation); | |||
| } | |||
|
|
|||
| public AzureCredentials(MSILoginInformation msiLoginInformation, string tenantId, AzureEnvironment environment) | |||
There was a problem hiding this comment.
Make the teantId as optional parameter as the last one and default value to null would be better, but not provide another API. Thanks.
|
@michaelelleby could you help update this PR? Thanks. |
|
|
… to allow talking to Azure AD through MSI
michaelelleby
force-pushed
the
msi-authentication-with-tenant
branch
from
b3e1ab5
to
fcd2030
Compare
|
@yaohaizh I have updated the PR, to avoid introducing any breaking changes to the SDK. |
yaohaizh
approved these changes
Jul 10, 2019
|
Thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661