Skip to content

Commit

Permalink
Don't allow thread interrupt when cancelling InstallationPut
Browse files Browse the repository at this point in the history
Because we don't have the separation of a thread pool delivering
responses vs a thread pool executing requests like Volley does, we could
get ourselves in a position where we cancel a user's ability to react to
an error in the middle of their error handler. We don't want that.
  • Loading branch information
marstr committed Aug 4, 2020
1 parent d0afc55 commit 2412818
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void addExpiration(Installation target) {
void cancelOutstandingUpdates() {
synchronized (NotificationHubInstallationAdapter.this) {
if (mOutstandingRetry != null) {
mOutstandingRetry.cancel(true);
mOutstandingRetry.cancel(false);
}
mRequestQueue.cancelAll(INSTALLATION_PUT_TAG);
}
Expand Down

0 comments on commit 2412818

Please sign in to comment.