-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xiaomi Installation #259
base: Xiaomi
Are you sure you want to change the base?
Conversation
Have these changes been tested with the following method to see if a valid request is generated? Bonus points if it's actually worked against our backend. azure-notificationhubs-dotnet/src/Microsoft.Azure.NotificationHubs/NotificationHubClient.cs Line 1092 in 5f9e17a
|
Yes I will do the actual integration tests today including this one. And thanks very much for the review too! 🙂 |
### Packages impacted by this PR - @azure/notification-hubs ### Issues associated with this PR ### Describe the problem that is addressed by this PR Adds Xiaomi support for Track 2 SDKs with registration, installation, send and send outcome operations. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ yes ### Provide a list of related PRs _(if any)_ - Azure/azure-notificationhubs-dotnet#261 - Azure/azure-notificationhubs-dotnet#260 - Azure/azure-notificationhubs-dotnet#259 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary) --------- Co-authored-by: Jeremy Meng <jeremy.ymeng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Things to consider before you submit the PR:
Description
Add Xiaomi Installation classes