Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Set-AzAutomationModule to use PUT call while updating modules with specific versions #16505

Merged
merged 14 commits into from
Dec 17, 2021
Merged

Updated Set-AzAutomationModule to use PUT call while updating modules with specific versions #16505

merged 14 commits into from
Dec 17, 2021

Conversation

adishiritwick
Copy link
Contributor

@adishiritwick adishiritwick commented Nov 26, 2021

Description

#12552

Set-AzAutomationModule was not importing updated Module because PATCH call was allowing updating of tags only. That's why replaced it with PUT call

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ghost ghost added the customer-reported label Nov 26, 2021
@ghost
Copy link

ghost commented Nov 26, 2021

Thank you for your contribution adishiritwick! We will review the pull request and get back to you soon.

@ghost
Copy link

ghost commented Nov 26, 2021

CLA assistant check
All CLA requirements met.

@msJinLei
Copy link
Contributor

msJinLei commented Nov 30, 2021

@dingmeng-xue
Copy link
Member

The title and description of pull request is vague. Please update it.

@adishiritwick adishiritwick changed the title used put call Updated Set-AzAutomationModule to use PUT call while updating modules with specific versions Dec 7, 2021
@dingmeng-xue
Copy link
Member

/azp run "azure-powershell - security-tools"

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@dingmeng-xue
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dingmeng-xue
Copy link
Member

@adishiritwick , as Lei mentioned, you need to update changelog. Otherwise, upcoming Az release cannot detect this change.

@dingmeng-xue
Copy link
Member

/azp run "azure-powershell - security-tools"

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@dingmeng-xue
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dingmeng-xue dingmeng-xue merged commit 8ab65b5 into Azure:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants