-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AzKeyStore with keyring in Linux #20296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
reviewed
Nov 30, 2022
.WithLinuxUnprotectedFile(); | ||
.WithLinuxKeyring(FileName, "default", "AzKeyStoreCache", | ||
new KeyValuePair<string, string>("AzureClientID", "Microsoft.Developer.Azure.PowerShell"), | ||
new KeyValuePair<string, string>("Microsoft.Developer.Azure.PowerShell", "1.0.0.0")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will we update this version? Does it mean the schema version of the serialized data?
isra-fel
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a question
msJinLei
added a commit
that referenced
this pull request
Dec 1, 2022
* Enable AzKeystore with keyring in Linux * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-preview Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> Fix AzKeystore bugs Fix the issue that secret cannot be retrived in headless linux Use the seperated file names for protected and unprotected AzKeystore Optimize the warning message for customers
msJinLei
added a commit
to msJinLei/azure-powershell
that referenced
this pull request
Dec 1, 2022
* Enable AzKeystore with keyring in Linux * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-preview Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> Fix AzKeystore bugs Fix the issue that secret cannot be retrived in headless linux Use the seperated file names for protected and unprotected AzKeystore Optimize the warning message for customers
Nickcandy
added a commit
that referenced
this pull request
Dec 1, 2022
msJinLei
added a commit
to msJinLei/azure-powershell
that referenced
this pull request
Dec 2, 2022
* Enable AzKeystore with keyring in Linux * Use the seperated file names for protected and unprotected AzKeystore * Optimize the warning message for customers * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-previewk
dingmeng-xue
added a commit
that referenced
this pull request
Dec 2, 2022
* Migrate SignalR from generation to main (#20230) * Move SignalR to main * Update ChangeLog.md * Update SignatureIssues.csv * Update SignatureIssues.csv Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Migrate ServiceBus from generation to release-2022-12-06 (#20316) * Move ServiceBus to release-2022-12-06 * Update ChangeLog.md * Update SignatureIssues.csv * Update ChangeLog.md Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Migrate EventHub from generation to release-2022-12-06 (#20315) * Move EventHub to release-2022-12-06 * Update ChangeLog.md * Update SignatureIssues.csv * Update ChangeLog.md Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * [RecoveryServices.Backup] Added support for passing DiskEncryptionSetId for Cross region restore (#20295) * Added CZR test case added CRR DES support re-recorded failed test * fixing the issue in playback mode * Update New-AzADAppCredential.md (#20317) Clarify examples. Also fixes the "Unable to get certificate thumbprint" issue in the portal, by giving an example of passing $CertificateThumbprint variable to the -CustomKeyIdentifier parameter. Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * {DesktopVitualization} Fix #20307: Update examples and add default values (#20322) Fixes #20307 Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Typo "resouce"→"resource" (#20321) https://learn.microsoft.com/en-us/powershell/module/az.datafactory/add-azdatafactoryv2dataflowdebugsessionpackage?view=azps-9.1.0 https://github.com/Azure/azure-powershell/blob/main/src/DataFactory/DataFactoryV2/help/Add-AzDataFactoryV2DataFlowDebugSessionPackage.md #PingMSFTDocs Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Enable AzKeyStore with keyring in Linux (#20296) * Enable AzKeystore with keyring in Linux * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-preview Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Move StackHCI to release-2022-12-06 (#20337) * Revert "Enable AzKeyStore with keyring in Linux (#20296)" (#20332) This reverts commit 97452c6. Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Fix test failure (#20342) * disable token cache for service principal (#20336) Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * Upgraded reference of azure-powershell-common to 1.3.67-preview (#20329) * Upgraded reference of azure-powershell-common to 1.3.67-preview * Update Common.Netcore.Dependencies.targets * Update ChangeLog.md Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Move Monitor to release-2022-12-06 (#20348) * CosmosDB Mongo API RBAC Release (#19595) * Add SDK source code * Update AssemblyInfo.cs * generated code * build fix * mongo rbac changes * update test records * Update New-AzCosmosDBMongoDBPrivilege.md * Update New-AzCosmosDBMongoDBPrivilege.md * Update New-AzCosmosDBMongoDBPrivilege.md * Update New-AzCosmosDBMongoDBPrivilegeResource.md * Update New-AzCosmosDBMongoDBRole.md * update help * update recordings * update recordings * update static analysis * Cosmos DB Service related changes * Added help files * Resolved nit * Static Analysis another nit * Update Az.CosmosDB.psd1 * Added service tests recording * Update ExampleIssues.csv * Update ExampleIssues.csv * Update New-AzCosmosDBAccount.md * Delete ExampleIssues.csv * Update New-AzCosmosDBMongoDBRoleDefinition.md Added backtick for cmdlets in examples that were separated in multi-lines * Update New-AzCosmosDBMongoDBUserDefinition.md * Update Update-AzCosmosDBMongoDBRoleDefinition.md * Update Update-AzCosmosDBMongoDBUserDefinition.md * update examples Co-authored-by: dingmeng-xue <dixue@microsoft.com> Co-authored-by: Praful Johari <pjohari@microsoft.com> Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * 2022-12-06 (#20318) Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> Co-authored-by: Himanshu Agarwal <himanshu.123j@gmail.com> Co-authored-by: Robin Malik <8790561+robinmalik@users.noreply.github.com> Co-authored-by: RakeshMohan-MSFT <49954584+RakeshMohanMSFT@users.noreply.github.com> Co-authored-by: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com> Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com> Co-authored-by: Ashwini Singh <42292682+ashwinisingh01@users.noreply.github.com> Co-authored-by: dingmeng-xue <dixue@microsoft.com> Co-authored-by: Praful Johari <pjohari@microsoft.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
msJinLei
added a commit
to msJinLei/azure-powershell
that referenced
this pull request
Dec 5, 2022
* Enable AzKeystore with keyring in Linux * Use the seperated file names for protected and unprotected AzKeystore * Optimize the warning message for customers * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-previewk
msJinLei
added a commit
to msJinLei/azure-powershell
that referenced
this pull request
Dec 5, 2022
* Enable AzKeystore with keyring in Linux * Use the seperated file names for protected and unprotected AzKeystore * Optimize the warning message for customers * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-previewk
1 task
msJinLei
added a commit
to msJinLei/azure-powershell
that referenced
this pull request
Dec 5, 2022
* Enable AzKeystore with keyring in Linux * Use the seperated file names for protected and unprotected AzKeystore * Optimize the warning message for customers * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-previewk
msJinLei
added a commit
to msJinLei/azure-powershell
that referenced
this pull request
Dec 5, 2022
* Enable AzKeystore with keyring in Linux * Use the seperated file names for protected and unprotected AzKeystore * Optimize the warning message for customers * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-previewk
msJinLei
added a commit
to msJinLei/azure-powershell
that referenced
this pull request
Dec 5, 2022
* Enable AzKeystore with keyring in Linux * Use the seperated file names for protected and unprotected AzKeystore * Optimize the warning message for customers * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-previewk
dolauli
pushed a commit
that referenced
this pull request
Dec 5, 2022
…-preview (#20364) * Added .NET SDK for new api version (#20099) Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Added new parameters to AzApplicationGatewayFirewallPolicySettings for CustomBlockResponseFeature (#19971) * Powershell changes for waf custom block response feature * Added test record * Update ChangeLog.md * Updating sdk version for 2022-07-01 * Updated tests * Update ChangeLog.md Co-authored-by: Akshay Murali <akshaymurali@microsoft.com> Co-authored-by: Adishree Mazumder <amazumder@microsoft.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * [UX] Fix the issues in UX files (#20198) * update the UX files * update the UX files * update the UX files * update the UX files * Remove the suppressed exceptions * Update subscriptions.json Co-authored-by: wyunchi-ms <yunwang@microsoft.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> * Fix error when repository is not provided (#20210) Fix the #20209 (Repository is not set but used in installation and updating) * Upgraded target framework of identity client (#20214) * adding new cmdlet - Get-AzApplicationGatewayWafDynamicManifests (#20217) * init commit * add help, move to singular not plural * fix help * upadte changelog * try to resolve conflict * init commit * get help file Co-authored-by: Alon Pelled <alpelled@microsoft.com> * [AKS] return NodeImageVersion for Get-AzAksNodePool (#20219) * Move Compute to main (#20227) * {ServiceFabric} Fix #20213: Fix a typo (#20228) Fixes #20213 * Move Botservice to main (#20229) * Store Secrets to Encrypted Storage (#19929) * Store secrets to encrypted storage * Uses unprotected files in Linux * Update Changelog.md * Fix the pipeline issue * Update src/Accounts/Authentication/KeyStore/AzKeyStore.cs Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Update ChangeLog.md (#20204) * Migrate Resources from generation to main (#20231) * Move Resources to main * Update ChangeLog.md Co-authored-by: Yabo Hu <yabhu@microsoft.com> * Move BotService to main (#20232) * Change letter case in example of New-AzStorageBlobSASToken (#20018) * {Network} Fix #11188: Add accepted values of Protocol (#20241) Fixes #11188 * [KeyVault] Fixed import key from encrypted certificate in `Add-AzKeyVaultKey` (#20239) * wip * pfxWebKeyConverter * Fixed certificate export parameter issue in Add-AzKeyVaultKey * polish * polish * polish * Update Changelog.md (#20233) * Update Changelog.md * Update src/BotService/Changelog.md Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Update online help url. (#20221) * Update ChangeLog.md (#20234) * Update ChangeLog.md * Update src/Compute/Compute/ChangeLog.md Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * {SQL} Fix #11023: Fix incorrect input type object reference (#20242) * {SQL} Fix #11023: Fix incorrect input type object reference Fixes #11023 * Update Restore-AzSqlInstanceDatabase.md * The example was using the wrong command (#20237) * Move StackHCI to main (#20253) * Fixed `Set-AzPolicySetDefinition` InternalServerError when the initiative is too large [#20238] (#20252) Co-authored-by: Xuejun Li <xuejl@microsoft.com> * [AKS] support NodeLabels and Tags (#20240) * [AKS] support NodeLabels * [AKS] support Tags * rename input parameters to singular nouns * remove Install-AzAksKubectl.md * Update docs.microsoft.com to learn.microsoft.com. (#20290) * Update URL of docs from docs.microsoft.com to learn.microsoft.com. (#20263) * [main - RedisCache|RedisEnterpriseCache|Relay|Reservations|ResourceGraph] domain name of online doc is changed from docs.microsoft.com to learn.microsoft.com. (#20286) * [main - NetworkFunction|Nginx|NotificationHubs|OperationalInsights|Orbital] domain name of online doc is changed from docs.microsoft.com to learn.microsoft.com. (#20283) * [main - ManagedServiceIdentity|ManagedServices|ManagementPartner|Maps|MariaDb] domain name of online doc is changed from docs.microsoft.com to learn.microsoft.com. (#20280) * [main - DeviceUpdate|DevSpaces|DevTestLabs|DigitalTwins|DiskPool] domain name of online doc is changed from docs.microsoft.com to learn.microsoft.com. (#20273) * [main - DataShare|DedicatedHsm|DeploymentManager|DesktopVirtualization|DeviceProvisioningServices] domain name of online doc is changed from docs.microsoft.com to learn.microsoft.com. (#20272) * [main - Dashboard|DataBox|DataBoxEdge|Databricks|Datadog] domain name of online doc is changed from docs.microsoft.com to learn.microsoft.com. (#20270) * Update ChangeLog.md (#20254) * Update ChangeLog.md * Update src/StackHCI/ChangeLog.md Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Implementation of interface IPSCmdletAction for test coverage (#19904) * Added implementation for interface ITestCoverage and registered in Azure session * Updated the reference of Azure PowerShell Common to 1.3.65-preview * Renamed environment variable from Azure_PS_TestCoverage to EnableTestCoverage * [Synapse] Support for setting spark pool configuration by artifact (#20024) * Updated and to support for setting spark pool configuration artifact by * add announce for deprecation of SparkConfigFilePath * modify change log * Enable token cache for client assertion login flow (#20297) * Add client assert code for upcoming change * cache token for client assertion * work around AssemblyInformationalVersion issue * changelog * Update README.md Co-authored-by: dingmeng-xue <dixue@microsoft.com> * Move StackHCI to main (#20306) * update changelog (#20312) * Migrate SignalR from generation to main (#20230) * Move SignalR to main * Update ChangeLog.md * Update SignatureIssues.csv * Update SignatureIssues.csv Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Migrate ServiceBus from generation to release-2022-12-06 (#20316) * Move ServiceBus to release-2022-12-06 * Update ChangeLog.md * Update SignatureIssues.csv * Update ChangeLog.md Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Migrate EventHub from generation to release-2022-12-06 (#20315) * Move EventHub to release-2022-12-06 * Update ChangeLog.md * Update SignatureIssues.csv * Update ChangeLog.md Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * [AKS] support NodeTaints and AksCustomHeaders (#20319) * [AKS] support NodeTaints * [AKS] support AksCustomHeader * [RecoveryServices.Backup] Added support for passing DiskEncryptionSetId for Cross region restore (#20295) * Added CZR test case added CRR DES support re-recorded failed test * fixing the issue in playback mode * Update New-AzADAppCredential.md (#20317) Clarify examples. Also fixes the "Unable to get certificate thumbprint" issue in the portal, by giving an example of passing $CertificateThumbprint variable to the -CustomKeyIdentifier parameter. Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * {DesktopVitualization} Fix #20307: Update examples and add default values (#20322) Fixes #20307 Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Typo "resouce"→"resource" (#20321) https://learn.microsoft.com/en-us/powershell/module/az.datafactory/add-azdatafactoryv2dataflowdebugsessionpackage?view=azps-9.1.0 https://github.com/Azure/azure-powershell/blob/main/src/DataFactory/DataFactoryV2/help/Add-AzDataFactoryV2DataFlowDebugSessionPackage.md #PingMSFTDocs Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Enable AzKeyStore with keyring in Linux (#20296) * Enable AzKeystore with keyring in Linux * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-preview Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Move StackHCI to release-2022-12-06 (#20337) * Show ExpressRouteGatewayBypass and EnablePrivatelinkFastPath Properties in VirtualNetworkGatewayConnection Resource (#20333) * Revert "Enable AzKeyStore with keyring in Linux (#20296)" (#20332) This reverts commit 97452c6. Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * Fix test failure (#20342) * disable token cache for service principal (#20336) Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * Upgraded reference of azure-powershell-common to 1.3.67-preview (#20329) * Upgraded reference of azure-powershell-common to 1.3.67-preview * Update Common.Netcore.Dependencies.targets * Update ChangeLog.md Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Move Monitor to release-2022-12-06 (#20348) * CosmosDB Mongo API RBAC Release (#19595) * Add SDK source code * Update AssemblyInfo.cs * generated code * build fix * mongo rbac changes * update test records * Update New-AzCosmosDBMongoDBPrivilege.md * Update New-AzCosmosDBMongoDBPrivilege.md * Update New-AzCosmosDBMongoDBPrivilege.md * Update New-AzCosmosDBMongoDBPrivilegeResource.md * Update New-AzCosmosDBMongoDBRole.md * update help * update recordings * update recordings * update static analysis * Cosmos DB Service related changes * Added help files * Resolved nit * Static Analysis another nit * Update Az.CosmosDB.psd1 * Added service tests recording * Update ExampleIssues.csv * Update ExampleIssues.csv * Update New-AzCosmosDBAccount.md * Delete ExampleIssues.csv * Update New-AzCosmosDBMongoDBRoleDefinition.md Added backtick for cmdlets in examples that were separated in multi-lines * Update New-AzCosmosDBMongoDBUserDefinition.md * Update Update-AzCosmosDBMongoDBRoleDefinition.md * Update Update-AzCosmosDBMongoDBUserDefinition.md * update examples Co-authored-by: dingmeng-xue <dixue@microsoft.com> Co-authored-by: Praful Johari <pjohari@microsoft.com> Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> * 2022-12-06 (#20318) * update changelog Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: Beisi Zhou <zazbs@qq.com> Co-authored-by: akshaym6 <35283938+akshaym6@users.noreply.github.com> Co-authored-by: Akshay Murali <akshaymurali@microsoft.com> Co-authored-by: Adishree Mazumder <amazumder@microsoft.com> Co-authored-by: Alex <108926104+Alex-wdy@users.noreply.github.com> Co-authored-by: wyunchi-ms <yunwang@microsoft.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> Co-authored-by: Dingmeng Xue <dixue@microsoft.com> Co-authored-by: alon-microsoft <31221093+alon-microsoft@users.noreply.github.com> Co-authored-by: Alon Pelled <alpelled@microsoft.com> Co-authored-by: Yan Xu <sheshouxy@gmail.com> Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com> Co-authored-by: RakeshMohan-MSFT <49954584+RakeshMohanMSFT@users.noreply.github.com> Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com> Co-authored-by: Yabo Hu <yabhu@microsoft.com> Co-authored-by: Mo Zaatar <mzaatar@users.noreply.github.com> Co-authored-by: Lucas Yao <53558334+LucasYao93@users.noreply.github.com> Co-authored-by: Ajay1250 <42563780+Ajay1250@users.noreply.github.com> Co-authored-by: Xuejun Li <xuejun.li@microsoft.com> Co-authored-by: Xuejun Li <xuejl@microsoft.com> Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: YanjunGao <85206987+yanjungao718@users.noreply.github.com> Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com> Co-authored-by: lijinpei2008 <31384087+lijinpei2008@users.noreply.github.com> Co-authored-by: Himanshu Agarwal <himanshu.123j@gmail.com> Co-authored-by: Robin Malik <8790561+robinmalik@users.noreply.github.com> Co-authored-by: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com> Co-authored-by: Jesus Arango <jearango@microsoft.com> Co-authored-by: Ashwini Singh <42292682+ashwinisingh01@users.noreply.github.com> Co-authored-by: Praful Johari <pjohari@microsoft.com>
msJinLei
added a commit
to msJinLei/azure-powershell
that referenced
this pull request
Dec 5, 2022
* Enable AzKeystore with keyring in Linux * Use the seperated file names for protected and unprotected AzKeystore * Optimize the warning message for customers * Update common library version. * Upgraded reference of azure-powershell-common to 1.3.67-previewk
msJinLei
added a commit
that referenced
this pull request
Dec 7, 2022
* Enable AzKeyStore with keyring in Linux (#20296) * Enable AzKeystore with keyring in Linux * Optimize the warning message for customers * Update common library version. * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyStoreFile
inAzureSession
instead of hardcoded file name for keystore cache fileDescription
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.