Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Enable AzKeyStore with keyring in Linux #20341

Merged
merged 2 commits into from Dec 7, 2022
Merged

[BugFix] Enable AzKeyStore with keyring in Linux #20341

merged 2 commits into from Dec 7, 2022

Conversation

msJinLei
Copy link
Contributor

@msJinLei msJinLei commented Dec 1, 2022 •
edited

Bug fix for #20296

  • Enable AzKeystore with keyring in Linux
  • Optimize the warning message for customers
  • Update common library version.

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@msJinLei msJinLei force-pushed the keystore_fix branch 4 times, most recently from 4f2f731 to 616ce44 Compare December 5, 2022 01:51
@msJinLei msJinLei marked this pull request as ready for review December 5, 2022 01:53
@msJinLei msJinLei force-pushed the keystore_fix branch 3 times, most recently from 8d960fb to abb64de Compare December 5, 2022 04:18
@msJinLei
Enable AzKeyStore with keyring in Linux (Azure#20296)
c18dda1 
* Enable AzKeystore with keyring in Linux
* Use the seperated file names for protected and unprotected AzKeystore
* Optimize the warning message for customers
* Update common library version.
* Upgraded reference of azure-powershell-common to 1.3.67-previewk
@msJinLei
Copy link
Contributor Author

msJinLei commented Dec 5, 2022

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei
Copy link
Contributor Author

msJinLei commented Dec 5, 2022

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei
Copy link
Contributor Author

msJinLei commented Dec 5, 2022

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei
Copy link
Contributor Author

msJinLei commented Dec 5, 2022

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

BethanyZhou
BethanyZhou previously approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msJinLei
Copy link
Contributor Author

msJinLei commented Dec 7, 2022

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@msJinLei msJinLei mentioned this pull request Dec 7, 2022
Closed
@msJinLei msJinLei closed this Dec 7, 2022
@msJinLei msJinLei reopened this Dec 7, 2022
@msJinLei msJinLei merged commit d687600 into Azure:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@BethanyZhou BethanyZhou BethanyZhou left review comments

Assignees
No one assigned
Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msJinLei @isra-fel @BethanyZhou