[Do not merge]: Bringing back provider registration during template deployment

src/Common/Commands.Common.Test/Mocks/MockClientFactory.cs

@@ -102,5 +102,10 @@ public override HttpClient CreateHttpClient(string serviceUrl, HttpMessageHandle
 
             return client;
         }
+
+        public override void RegisterCustomProviders(IEnumerable<string> providers)
+        {
+            throw new NotImplementedException();
+        }
     }
 }

src/Common/Commands.Common/Common/AzurePowerShellClientFactory.cs

@@ -21,6 +21,7 @@
 using System.Linq;
 using System.Collections.Generic;
 using Microsoft.WindowsAzure.Management;
+using Microsoft.Azure.Management.Resources.Models;
 
 namespace Microsoft.WindowsAzure.Commands.Common.Common
 {
@@ -44,6 +45,41 @@ public override TClient CreateClient<TClient>(AzureContext context, AzureEnviron
 
             return client;
         }
+
+        public override void RegisterCustomProviders(IEnumerable<string> providers)
+        {
+            var context = AzureSession.CurrentContext;
+            var registeredProviders = context.Subscription.GetPropertyAsArray(
+                                            AzureSubscription.Property.RegisteredResourceProviders);
+            var successfullyRegisteredProvider = new List<string>();
+            var creds = AzureSession.AuthenticationFactory.GetSubscriptionCloudCredentials(context);
+
+            var requiredProviders = providers.Where(p => !registeredProviders.Contains(p))
+                                             .ToList();
+
+            if (requiredProviders.Count > 0)
+            {
+                using (var client = AzureSession.ClientFactory.CreateCustomClient<ResourceManagementClient>(
+                    creds,
+                    context.Environment.GetEndpointAsUri(AzureEnvironment.Endpoint.ResourceManager)))
+                {
+                    foreach (var provider in requiredProviders)
+                    {
+                        try
+                        {
+                            client.Providers.Register(provider);
+                            successfullyRegisteredProvider.Add(provider);
+                        }
+                        catch
+                        {
+                            // Ignore this as the user may not have access to Sparta endpoint or the provider is already registered
+                        }
+                    }
+                }
+
+                UpdateSubscriptionRegisteredProviders(context.Subscription, successfullyRegisteredProvider);
+            }
+        }
 
         /// <summary>
         /// Registers resource providers for Sparta.

src/Common/Commands.Common/Factories/ClientFactory.cs

@@ -23,7 +23,7 @@
 
 namespace Microsoft.WindowsAzure.Commands.Common.Factories
 {
-    public class ClientFactory : IClientFactory
+    public abstract class ClientFactory : IClientFactory
     {
         private static readonly char[] uriPathSeparator = { '/' };
 
@@ -136,5 +136,7 @@ public static HttpClientHandler CreateHttpClientHandler(string endpoint, ICreden
             // Our handler is ready
             return clientHandler;
         }
+
+        public abstract void RegisterCustomProviders(IEnumerable<string> providers);
     }
 }

src/Common/Commands.Common/Interfaces/IClientFactory.cs

@@ -17,6 +17,7 @@
 using Microsoft.WindowsAzure.Commands.Common.Models;
 using Microsoft.WindowsAzure.Common;
 using System;
+using System.Collections.Generic;
 
 namespace Microsoft.WindowsAzure.Commands.Common
 {
@@ -31,5 +32,7 @@ public interface IClientFactory
         HttpClient CreateHttpClient(string endpoint, ICredentials credentials);
 
         HttpClient CreateHttpClient(string endpoint, HttpMessageHandler effectiveHandler);
+
+        void RegisterCustomProviders(IEnumerable<string> providers);
     }
 }

src/ResourceManager/Resources/Commands.Resources/Models.ResourceGroups/ResourceClient.ResourceManager.cs

@@ -22,6 +22,9 @@
 using Microsoft.Azure.Management.Resources.Models;
 using Microsoft.WindowsAzure;
 using ProjectResources = Microsoft.Azure.Commands.Resources.Properties.Resources;
+using Microsoft.WindowsAzure.Commands.Common.Factories;
+using Microsoft.WindowsAzure.Commands.Common;
+using Microsoft.WindowsAzure.Commands.Common.Models;
 
 namespace Microsoft.Azure.Commands.Resources.Models
 {
@@ -321,13 +324,14 @@ public virtual PSResourceGroupDeployment ExecuteDeployment(CreatePSResourceGroup
                 WriteWarning("The StorageAccountName parameter is no longer used and will be removed in a future release. Please update scripts to remove this parameter.");
             }
 
+            AzureSession.ClientFactory.RegisterCustomProviders(validationInfo.RequiredProviders.Select(p => p.Namespace.ToLower()));
             ResourceManagementClient.Deployments.CreateOrUpdate(parameters.ResourceGroupName, parameters.DeploymentName, deployment);
             WriteVerbose(string.Format("Create template deployment '{0}'.", parameters.DeploymentName));
             Deployment result = ProvisionDeploymentStatus(parameters.ResourceGroupName, parameters.DeploymentName, deployment);
 
             return result.ToPSResourceGroupDeployment(parameters.ResourceGroupName);
         }
-
+        
         private string GenerateDeploymentName(CreatePSResourceGroupDeploymentParameters parameters)
         {
             if (!string.IsNullOrEmpty(parameters.DeploymentName))