Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Tags from New-AzureRmSqlDatabaseCopy #7476

Closed
wants to merge 1 commit into from
Closed

Remove -Tags from New-AzureRmSqlDatabaseCopy #7476

wants to merge 1 commit into from

Conversation

dalibormesaric
Copy link
Contributor

Description

Based on #6049 -Tags parameter is not supported and should be removed in order for the documentation to be correct.

Checklist

Based on #6049 -Tags parameter is not supported
@msftclas
Copy link

msftclas commented Oct 5, 2018

CLA assistant check
All CLA requirements met.

@maddieclayton
Copy link
Contributor

@dalibormesaric I think the correct fix for the bug is to correctly add the tags rather than remove the parameter.

@jaredmoo Can you comment on the ETA of the fix for this issue? #6049

@adxsdkps
Copy link
Collaborator

adxsdkps commented Oct 5, 2018

Can one of the admins verify this patch?

@jaredmoo
Copy link
Member

jaredmoo commented Oct 5, 2018

The original issue should be fixed since #5949 . Does the issue repro with latest version of AzureRM.SQL ?

@dalibormesaric
Copy link
Contributor Author

@jaredmoo I just tried it in Cloud Shell

Copy link
Contributor

@maboja-msft maboja-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalibormesaric removing Tags parameter from the command is not the right solution here. The problem is that Tags are not propagated to Communicator call to create or update database and that need to be fixed. If you want to do that, it would be great, otherwise let us know and I will fix it.

@dalibormesaric
Copy link
Contributor Author

dalibormesaric commented Oct 9, 2018

@maboja-msft I would really like to try to fix this!

I also agree with you, but docs should correspond the API

@MiYanni
Copy link
Contributor

MiYanni commented Oct 12, 2018

@dalibormesaric CloudShell runs Az (not AzureRM). As per @jaredmoo's request, please try to reproduce the issue in AzureRM.SQL. Also, removing the documentation is not the correct approach here (since you aren't actually changing what is represented in the code). Please continue the discussion about this in the issue: #6049

@MiYanni MiYanni closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants