Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Fix mapping of boolean record_mode to underlying vcr modes #22

Closed
wants to merge 1 commit into from

Conversation

v-iam
Copy link
Contributor

@v-iam v-iam commented Jun 23, 2017

This PR fixes #21 by passing an appropriate string for VCR()'s record_mode parameter rather than a boolean like it was doing before.

@msftclas
Copy link

@v-iam,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files          10       10           
  Lines         382      382           
  Branches       58       58           
=======================================
  Hits          184      184           
  Misses        194      194           
  Partials        4        4
Impacted Files Coverage Δ
src/azure_devtools/scenario_tests/base.py 38.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d4e3c...b053ac6. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Sep 5, 2017

Duplicate of merged #30

@lmazuel lmazuel closed this Sep 5, 2017
@troydai troydai deleted the fix-record-mode-mapping branch May 4, 2018 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping to underlying VCR record modes is wrong
4 participants