Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarSQL templates: Fixed multiple typos and added generation a fqdn certificate #4692

Merged
merged 5 commits into from Jun 1, 2018

Conversation

rajbos
Copy link
Contributor

@rajbos rajbos commented May 30, 2018

Best Practice Checklist

Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md

  1. uri's compatible with all clouds (Stack, China, Government)
  2. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken
  3. Use resourceGroup().location for resource locations
  4. Folder names for artifacts (nestedtemplates, scripts, DSC)
  5. Use literal values for apiVersion (no variables)
  6. Parameter files (GEN-UNIQUE for value generation and no "changemeplease" values
  7. $schema and other uris use https
  8. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment.
  9. Update the metadata.json with the current date

For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

  • Fixed multiple typos
  • Added usage of the FQDN to the creation of the self signed cert to prevent TLS\SSL issues on e.g. a custom VSTS Agent installation. The old method resulted in an invalid cert to trust and costed some time to fix.

To prevent having a self signed cert that cannot be registered on e.g. a VSTS custom agent, I'm using the fqdn of the new website to generate a valid cert with
@msftclas
Copy link

msftclas commented May 30, 2018

CLA assistant check
All CLA requirements met.

@bmoore-msft bmoore-msft merged commit ab7907f into Azure:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants