Fixes and Enhancements #6184
Merged
Fixes and Enhancements #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StartAutomating
commented
May 16, 2019
StartAutomating
commented
- Changing Default to Not Use Pester (can still be run in Pester with -Pester)
- Fixed Location-Should-Not-Be-Hardcoded ( templateObject was being passed incorrectly)
- Fixed Min-and-Max-Value-Are-Numbers ( incomplete error messages and bad pairing)
- Enhanced test for blanks (added whitelist of acceptable blanks)
- Enhanced test for apiVersions (enabling more exotic preview versions, handling resource type inheritance)
… -Pester) * Fixed Location-Should-Not-Be-Hardcoded ( templateObject was being passed incorrectly) * Fixed Min-and-Max-Value-Are-Numbers ( incomplete error messages and bad pairing) * Enhanced test for blanks (added whitelist of acceptable blanks) * Enhanced test for apiVersions (enabling more exotic preview versions, handling resource type inheritance)
bmoore-msft
requested changes
May 20, 2019
test/template-tests/testcases/deploymentTemplate/Location-Should-Not-Be-Hardcoded.test.ps1
Outdated
Show resolved
Hide resolved
test/template-tests/testcases/deploymentTemplate/Location-Should-Not-Be-Hardcoded.test.ps1
Outdated
Show resolved
Hide resolved
test/template-tests/testcases/deploymentTemplate/apiVersions-Should-Be-Recent.test.ps1
Show resolved
Hide resolved
test/template-tests/testcases/deploymentTemplate/apiVersions-Should-Be-Recent.test.ps1
Outdated
Show resolved
Hide resolved
* Fixing Message for apiVersion Test
|
Also found another (unrelated bug) here: $TemplateText needs to be passed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.