Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unreferenced network/resource-manager/Microsoft.Network/ examples #5634

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Apr 12, 2019

These get flagged by Avocado. Likely just copied between versions after they got replaced or removed in newer versions

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2019

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2019

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2019

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anton-evseev
Copy link
Contributor

anton-evseev commented Apr 16, 2019

Some of those examples are legit and should be added to specs instead of getting removed. I'll take a closer look tomorrow and fix that in network-march-release branch

@nschonni
Copy link
Contributor Author

@number213 sounds good, if you figure out which should stay, you can flag them here and I'll rebase them out

@anton-evseev
Copy link
Contributor

@nschonni opened PR with fixes: #5675

@nschonni nschonni force-pushed the fix--Unreferenced-network/resource-manager/Microsoft.Network/-examples branch from 1088671 to f099679 Compare April 17, 2019 20:22
@nschonni
Copy link
Contributor Author

@number213 found a few extras still unreferenced after rebasing

@anton-evseev
Copy link
Contributor

@nschonni thanks for noticing, I missed them somehow (and avocado's job was green too)
Opened PR to fix them: #5693

@nschonni
Copy link
Contributor Author

@NumberByColors sounds good, i'll close this then

@nschonni nschonni closed this Apr 18, 2019
@nschonni nschonni deleted the fix--Unreferenced-network/resource-manager/Microsoft.Network/-examples branch April 18, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants