fix schema property naming #6901
Conversation
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
| @@ -828,18 +828,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "KnowledgebaseEnvironment": { | |||
There was a problem hiding this comment.
Is this removal considered as a breaking change? Breaking changes should not happen in a stable version
There was a problem hiding this comment.
My understanding is that this is only used once for this file's redundant schema reference. I would assume that removing this has no breaking impact on the schema. Are you aware of a reason this would be a breaking change?
There was a problem hiding this comment.
So you are saying that removal of this schema will not cause a breaking change. If so, I am ok with this, and will approve this as soon as azure api board responds
There was a problem hiding this comment.
Is there a change to the REST API that motivated this change?
There was a problem hiding this comment.
Per offline conversation, this is not a change to the public REST API. Thus, no need for the Azure API review board to review.
There was a problem hiding this comment.
Hi @alargeasteroid after a check on SDK, this removal will cause a breaking change on go SDK (we have a tool for that). But in my opinion, this situation happens day to day, we always get unexpected breaking changes in SDK and in semver we will hold this kind of breaking change to next major version release
ArcturusZhang
added
the
APIStewardshipBoard-ReviewRequested
johanste
removed
the
APIStewardshipBoard-ReviewRequested
|
Approved and merged |
* new easm api * updating based on semantics * updating based on semantics * updating easm * updating easm * updating versions and rp name * updating description * updates based on comments * fixing validation errors Co-authored-by: Sonia Burney <sonia.burney@riskiq.net>
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.