Fix compilation on Visual Studio 2017 #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgen
requested review from
RickWinter,
ahsonkhan,
antkmsft,
vhvb1989,
gearama and
LarryOsterman
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution jorgen! We will review the pull request and get back to you soon. |
antkmsft
approved these changes
Feb 13, 2023
RickWinter
approved these changes
Feb 13, 2023
|
Thank you @jorgen! We are happy to take your fix. |
azure-sdk
added a commit
to azure-sdk/vcpkg
that referenced
this pull request
May 4, 2023
## 1.9.0 (2023-05-04) ### Features Added - Added the ability to ignore invalid certificate common name for TLS connections in WinHTTP transport. - Added `DisableTlsCertificateValidation` in `TransportOptions`. - Added `TokenCredential::GetCredentialName()` to be utilized in diagnostic messages. If you have any custom implementations of `TokenCredential`, it is recommended to pass the name of your credential to `TokenCredential` constructor. The old parameterless constructor is deprecated. - Added support for challenge-based and multi-tenant authentication. ### Bugs Fixed - Fixed the UUID generation so the variant is RFC 4122 conforming. ### Other Changes - [[microsoft#4352]](Azure/azure-sdk-for-cpp#4352) Fixed compilation error on Visual Studio 2017. (A community contribution, courtesy of _[jorgen](https://github.com/jorgen)_) ### Acknowledgments Thank you to our developer community members who helped to make Azure Core better with their contributions to this release: - Jorgen Lind _([GitHub](https://github.com/jorgen))_
BillyONeal
pushed a commit
to microsoft/vcpkg
that referenced
this pull request
May 4, 2023
* [azure-security-keyvault-administration-cpp] Update to 4.0.0-beta.3 * [azure-identity-cpp] Update to 1.5.0 ## 1.5.0 (2023-05-04) ### Features Added - Added support for challenge-based and multi-tenant authentication. - Added `DefaultAzureCredential`. ### Bugs Fixed - [[#4443]](Azure/azure-sdk-for-cpp#4443) Fixed potentially high CPU usage on Windows. ### Other Changes - Improved diagnostics to utilize `Azure::Core::Credentials::TokenCredential::GetCredentialName()`. - Improved log messages. * [azure-core-cpp] Update to 1.9.0 ## 1.9.0 (2023-05-04) ### Features Added - Added the ability to ignore invalid certificate common name for TLS connections in WinHTTP transport. - Added `DisableTlsCertificateValidation` in `TransportOptions`. - Added `TokenCredential::GetCredentialName()` to be utilized in diagnostic messages. If you have any custom implementations of `TokenCredential`, it is recommended to pass the name of your credential to `TokenCredential` constructor. The old parameterless constructor is deprecated. - Added support for challenge-based and multi-tenant authentication. ### Bugs Fixed - Fixed the UUID generation so the variant is RFC 4122 conforming. ### Other Changes - [[#4352]](Azure/azure-sdk-for-cpp#4352) Fixed compilation error on Visual Studio 2017. (A community contribution, courtesy of _[jorgen](https://github.com/jorgen)_) ### Acknowledgments Thank you to our developer community members who helped to make Azure Core better with their contributions to this release: - Jorgen Lind _([GitHub](https://github.com/jorgen))_ --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to be able to compile on Visual Studio 2017.