Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with commit "[vcpkg.cmake] Remove Windows SDK detection. Let cmake detect it #4352

Closed
0-wiz-0 opened this issue Sep 26, 2018 · 2 comments
Labels
requires:repro The issue is not currently repro-able

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Sep 26, 2018

libzip is a cross-platform zip library. I'm one of the authors.
We have no particular Windows knowledge. A user contributed an appveyor setup for it, which worked fine until this commit:
f9d4692#diff-464a170117fa96bf98b2f8d224bf503c
Since then, the UWP builds (for all of arm/arm64/win/win64) of libzip on appveyor (see https://ci.appveyor.com/project/0-wiz-0/libzip/history) are broken, ending with:

mkdir build
cd build
cmake -DCMAKE_TOOLCHAIN_FILE=%cd%/../vcpkg/scripts/buildsystems/vcpkg.cmake .. -G "%GENERATOR%" %CMAKE_OPTS%
CMake Error at CMakeLists.txt:8 (PROJECT):
  Visual Studio 15 2017 supports Windows Store '8.0', '8.1' and '10.0', but
  not ''.  Check CMAKE_SYSTEM_VERSION.
-- Configuring incomplete, errors occurred!
See also "C:/projects/libzip/build/CMakeFiles/CMakeOutput.log".

(The non-UWP builds still work.)

I'm not saying this needs to be backed out, but I'd appreciate help a lot on how to get the libzip appveyor builds working again. Thanks.

@Cheney-W Cheney-W added the requires:repro The issue is not currently repro-able label Jan 23, 2019
@Cheney-W
Copy link
Contributor

@0-wiz-0 Thanks for your feedback. I could install libzip:(x64/x86/arm)-uwp successfully with VS 2017 15.9.11. Please reopen a new issue if it is still a problem for you!

@0-wiz-0
Copy link
Author

0-wiz-0 commented Apr 19, 2019

The solution was to define CMAKE_SYSTEM_VERSION manually, see e.g.
nih-at/libzip@a9028c9

azure-sdk added a commit to azure-sdk/vcpkg that referenced this issue May 4, 2023
## 1.9.0 (2023-05-04)

### Features Added

- Added the ability to ignore invalid certificate common name for TLS connections in WinHTTP transport.
- Added `DisableTlsCertificateValidation` in `TransportOptions`.
- Added `TokenCredential::GetCredentialName()` to be utilized in diagnostic messages. If you have any custom implementations of `TokenCredential`, it is recommended to pass the name of your credential to `TokenCredential` constructor. The old parameterless constructor is deprecated.
- Added support for challenge-based and multi-tenant authentication.

### Bugs Fixed

- Fixed the UUID generation so the variant is RFC 4122 conforming.

### Other Changes

- [[microsoft#4352]](Azure/azure-sdk-for-cpp#4352) Fixed compilation error on Visual Studio 2017. (A community contribution, courtesy of _[jorgen](https://github.com/jorgen)_)

### Acknowledgments

Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Jorgen Lind _([GitHub](https://github.com/jorgen))_
BillyONeal pushed a commit that referenced this issue May 4, 2023
* [azure-security-keyvault-administration-cpp] Update to 4.0.0-beta.3

* [azure-identity-cpp] Update to 1.5.0
## 1.5.0 (2023-05-04)

### Features Added

- Added support for challenge-based and multi-tenant authentication.
- Added `DefaultAzureCredential`.

### Bugs Fixed

- [[#4443]](Azure/azure-sdk-for-cpp#4443) Fixed potentially high CPU usage on Windows.

### Other Changes

- Improved diagnostics to utilize `Azure::Core::Credentials::TokenCredential::GetCredentialName()`.
- Improved log messages.

* [azure-core-cpp] Update to 1.9.0
## 1.9.0 (2023-05-04)

### Features Added

- Added the ability to ignore invalid certificate common name for TLS connections in WinHTTP transport.
- Added `DisableTlsCertificateValidation` in `TransportOptions`.
- Added `TokenCredential::GetCredentialName()` to be utilized in diagnostic messages. If you have any custom implementations of `TokenCredential`, it is recommended to pass the name of your credential to `TokenCredential` constructor. The old parameterless constructor is deprecated.
- Added support for challenge-based and multi-tenant authentication.

### Bugs Fixed

- Fixed the UUID generation so the variant is RFC 4122 conforming.

### Other Changes

- [[#4352]](Azure/azure-sdk-for-cpp#4352) Fixed compilation error on Visual Studio 2017. (A community contribution, courtesy of _[jorgen](https://github.com/jorgen)_)

### Acknowledgments

Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Jorgen Lind _([GitHub](https://github.com/jorgen))_

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
azure-sdk added a commit to azure-sdk/vcpkg that referenced this issue Apr 9, 2024
## 1.11.3 (2024-04-09)

### Bugs Fixed

- [[microsoft#5450]](Azure/azure-sdk-for-cpp#5450) Reverted libcurl connection pool to use more conservative caching strategy.
- [[microsoft#4352]](Azure/azure-sdk-for-cpp#5371) Fixed compilation error on Visual Studio 2017. (A community contribution, courtesy of _[morten-ofstad](https://github.com/morten-ofstad)_)

### Acknowledgments

Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Morten Ofstad _([GitHub](https://github.com/morten-ofstad))_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires:repro The issue is not currently repro-able
Projects
None yet
Development

No branches or pull requests

2 participants