Skip to content

Commit

Permalink
[KeyVault] Removing embedded models in azkeys (#16933)
Browse files Browse the repository at this point in the history
* removing embedded models in keyvault libraries

* updating autorest version and regenerating

* removing from autorest.md file

* renaming for consistency

* KeyAttributes -> KeyProperties

* removing interfaces, returning structs directly

* Update sdk/keyvault/azkeys/models.go

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>

* build fix

* renaming

* fixing example name

* test fix

* undoing changes to azsecrets

* renamings

* formatting

* removing stuttering, adding Possible***Values methods

* fixing web keys

* formatting

* Clients returned by value

* formatting

* prepare release

* return clients by pointer

* return pagers/pollers by ref

* Update sdk/keyvault/azkeys/client.go

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>

* charles suggestion

* removing comment

* pagers

* constants

* encryptionalgorithm -> ExportEncryAlg

* fixing broken KV test

* ignoring error altogether for broken test

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
  • Loading branch information
seankane-msft and chlowell committed Mar 3, 2022
1 parent b06f24e commit 1b5439d
Show file tree
Hide file tree
Showing 24 changed files with 720 additions and 2,927 deletions.
17 changes: 9 additions & 8 deletions sdk/keyvault/azkeys/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,24 @@
# Release History

## 0.3.1 (Unreleased)
## 0.4.0 (2022-03-08)

### Features Added
* Adds the `ReleasePolicy` parameter to the `UpdateKeyPropertiesOptions` struct.
* Adds the `Immutable` boolean to the `KeyReleasePolicy` model.
* Added a `ToPtr` method on `KeyType` constant

### Breaking Changes
* Changed the `Data` to `EncodedPolicy` on the `KeyReleasePolicy` struct.
* Changed the `Tags` properties from `map[string]*string` to `map[string]string`.
* Changed the `Updated`, `Created`, and `Expires` properties to `UpdatedOn`, `CreatedOn`, and `ExpiresOn`.
* Renamed `JSONWebKeyOperation` to `KeyOperation`.
* Renamed `JSONWebKeyCurveName` to `KeyCurveName`
* Renamed `JSONWebKeyOperation` to `Operation`.
* Renamed `JSONWebKeyCurveName` to `CurveName`
* Prefixed all KeyType constants with `KeyType`
* Changed `KeyBundle` to `KeyVaultKey` and `DeletedKeyBundle` to `DeletedKey`
* Renamed `KeyAttributes` to `KeyProperties`
* Renamed `ListKeyVersions` to `ListPropertiesOfKeyVersions`
* Removed `Attributes` struct
* Changed `CreateOCTKey`/`Response`/`Options` to `CreateOctKey`/`Response`/`Options`

### Bugs Fixed

### Other Changes

## 0.3.0 (2022-02-08)

### Breaking Changes
Expand Down
7 changes: 2 additions & 5 deletions sdk/keyvault/azkeys/autorest.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@ These settings apply only when `--go` is specified on the command line.
go: true
version: "^3.0.0"
input-file:
- https://github.com/Azure/azure-rest-api-specs/blob/8a061f1e9031450b9eb5546d242f2a28c93eaa69/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.3-preview/common.json
- https://github.com/Azure/azure-rest-api-specs/blob/8a061f1e9031450b9eb5546d242f2a28c93eaa69/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.3-preview/keys.json
- https://github.com/Azure/azure-rest-api-specs/blob/8a061f1e9031450b9eb5546d242f2a28c93eaa69/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.3-preview/rbac.json
- https://github.com/Azure/azure-rest-api-specs/blob/8a061f1e9031450b9eb5546d242f2a28c93eaa69/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.3-preview/securitydomain.json
- https://github.com/Azure/azure-rest-api-specs/blob/ecdce42924ed0f7e60a32c74bc0eb674ca6d4aae/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.3-preview/keys.json
license-header: MICROSOFT_MIT_NO_VERSION
clear-output-folder: true
output-folder: internal/generated
Expand All @@ -18,6 +15,6 @@ openapi-type: "data-plane"
security: "AADToken"
security-scopes: "https://vault.azure.net/.default"
use: "@autorest/go@4.0.0-preview.35"
module-version: 0.3.0
module-version: 0.4.0
export-clients: true
```
Loading

0 comments on commit 1b5439d

Please sign in to comment.