Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo is over 100 MB of Go source code and growing #1969

Closed
rsc opened this issue Jun 5, 2018 · 6 comments
Closed

repo is over 100 MB of Go source code and growing #1969

rsc opened this issue Jun 5, 2018 · 6 comments
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@rsc
Copy link

rsc commented Jun 5, 2018

For vgo I put in a limit of 100 MB of uncompressed source code for any module, thinking surely that would be plenty. (There must be some limit, of course, or else we fill people's disks when receiving a zip bomb.)

It looks like this project recently crossed the 100 MB line, just for the go sources in it:

$ git clone https://github.com/Azure/azure-sdk-for-go
$ cd azure-sdk-for-go
$ ls -lR | grep '\.go$' | awk '{s+=$5}END{print s}'
116335208
$ 

Sizes for recent major versions:

v14.0.0 66,432,773
v15.0.0 80,010,402
v16.0.0 114,745,301
v17.0.0 116,277,454

I am going to raise the limit to 500 MB but I wanted to file this issue to let you know about the problem, so that you can look to see if the rate of growth here is really intentional and/or think about whether to break this repo into multiple modules.

gopherbot pushed a commit to golang/vgo that referenced this issue Jun 5, 2018
This limit applies not just to the compressed zip file but also
to the total of the uncompressed contents.

github.com/Azure/azure-sdk-for-go has 116,335,208 bytes
of Go source files today. That exceeds the previous limit of
100 MB (104,857,600 bytes). Raise the limit.

For Azure/azure-sdk-for-go#1969.

Change-Id: Ibcc3b7b3fe375e2e17cc16210542b1d06293ba08
Reviewed-on: https://go-review.googlesource.com/116355
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@joshgav joshgav self-assigned this Jun 8, 2018
@joshgav
Copy link
Contributor

joshgav commented Jun 8, 2018

Thanks for letting us know @rsc. This will be a consideration for us as we adopt modules here.

@marstr
Copy link
Member

marstr commented Jun 8, 2018

Howdy @rsc, thanks for thinking of us!

We've been thinking about splitting up this repository for sometime, but have balked at the overhead of managing a repository per Azure Resource Provider. Modules present a solution that we're excited about. Tentatively, we intend on shipping each of the subfolders in "services" and "profiles" as its own module with its own semver.

@joshgav joshgav removed their assignment Jun 12, 2018
@joshgav
Copy link
Contributor

joshgav commented Jun 13, 2018

related: golang/vgo@0cf06bb

@jhendrixMSFT
Copy link
Member

Work to split each RP/API version tuple into modules is in progress, tracked in #2993

@RickWinter RickWinter added this to the Backlog milestone Jul 12, 2021
@RickWinter RickWinter modified the milestones: Backlog, [2021] August Dec 29, 2021
@RickWinter RickWinter added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. feature-request This issue requires a new behavior in the product in order be resolved. labels Dec 29, 2021
@tombuildsstuff
Copy link
Contributor

x-post: #18209

@ceejatec
Copy link

Indeed. If it was thought that 100MB was too big 3 years ago, how did it end up at 512MB+ today?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

7 participants