Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issues in Subnet., Network, NIC #1140

Merged
merged 13 commits into from
Sep 30, 2016
Merged

fixing issues in Subnet., Network, NIC #1140

merged 13 commits into from
Sep 30, 2016

Conversation

martinsawicki
Copy link

@martinsawicki martinsawicki commented Sep 29, 2016

API change from beta2:

  • renaming Subnet#networkSecurityGroup() as getNetworkSecurityGroup() since it makes an actual call to Azure
  • renaming Network#dsnServerIPs() as dnsServerIps() to follow naming conventions

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@martinsawicki martinsawicki changed the title fixing incorrect naming of a method in Subnet fixing issue in Subnet and Network Sep 29, 2016
@martinsawicki martinsawicki changed the title fixing issue in Subnet and Network fixing issues in Subnet., Network, NIC Sep 29, 2016
@martinsawicki martinsawicki merged commit 13e8c08 into Azure:master Sep 30, 2016
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
fixing issues in Subnet., Network, NIC
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
fixing issues in Subnet., Network, NIC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants