Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename delete to deleteByBlah to align with getByBlahs #1236

Merged
merged 4 commits into from
Oct 25, 2016

Conversation

jianghaolu
Copy link
Contributor

@jianghaolu jianghaolu commented Oct 25, 2016

This is a continuation of #1235.

API breakages:

  • collections().delete(String id) -> collections().deleteById(String id)
  • resourceGroups().delete(String id) -> resourceGroups().deleteByName(String name)
  • collections().delete(String groupName, String name) -> collections().deleteByGroup(String groupName, String name)

@martinsawicki
Copy link

does this introduce breaking changes from beta3?
If so, pls use the compat-breaks tag and list the exact API changes in the PR comments.
For example, see: #1140

@martinsawicki martinsawicki merged commit 560aa18 into Azure:master Oct 25, 2016
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
Rename delete to deleteByBlah to align with getByBlahs
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Mar 21, 2019
…nge is related to PR Azure#1011 where generalized method was introduced. (Azure#1236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants