Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Profiles to Enable OS Specific Dependencies #21223

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented May 6, 2021

Fixes #21217

This PR uses properties and activation profiles to enable building azure-core with OS specific native binaries for Boring SSL.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels May 6, 2021
@alzimmermsft alzimmermsft self-assigned this May 6, 2021
@check-enforcer
Copy link

check-enforcer bot commented May 6, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@alzimmermsft alzimmermsft marked this pull request as ready for review May 11, 2021 18:51
@alzimmermsft alzimmermsft requested review from srnagar and removed request for hemanttanwar July 20, 2021 17:26
@alzimmermsft alzimmermsft merged commit c84de5d into Azure:main Jul 22, 2021
@alzimmermsft alzimmermsft deleted the AzCore_OSProfiles branch July 22, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Using Profiles when Including OS Specific Dependencies
2 participants