Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Additional Environment Configurations #23435

Merged
merged 6 commits into from
Aug 10, 2021
Merged

Support Additional Environment Configurations #23435

merged 6 commits into from
Aug 10, 2021

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Aug 9, 2021 •
edited
Loading

Fixes #6613
Fixes #23383

This PR adds additional environment configurations for configuring an SDK.

Configuration Name Description
AZURE_REQUEST_RETRY_COUNT Sets the number of retries that will be attempted when an error response is retriable.
AZURE_REQUEST_CONNECT_TIMEOUT Sets the timeout, in milliseconds, that will be used when attempting to connect to a remote host.
AZURE_REQUEST_WRITE_TIMEOUT Sets the timeout interval, in milliseconds, allowed between each byte written in a request.
AZURE_REQUEST_RESPONSE_TIMEOUT Sets the timeout, in milliseconds, for a request to receive a response.
AZURE_REQUEST_READ_TIMEOUT Sets the timeout interval, in milliseconds, allowed between each byte read in a response.

Additionally, this PR deprecates a constructor in UserAgentPolicy.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core HttpClient labels Aug 9, 2021
@alzimmermsft alzimmermsft self-assigned this Aug 9, 2021
@alzimmermsft alzimmermsft marked this pull request as ready for review August 9, 2021 21:55
@alzimmermsft alzimmermsft enabled auto-merge (squash) August 10, 2021 20:20
@alzimmermsft alzimmermsft merged commit 703d97b into Azure:main Aug 10, 2021
@alzimmermsft alzimmermsft deleted the AzCore_AdditionalEnvironmentConfigurations branch August 10, 2021 21:01
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Apr 10, 2023
CodeGen from PR 23435 in Azure/azure-rest-api-specs
e3f33ec 
updated specs (Azure#23435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. HttpClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Additional Environment Configurations Remove UserAgentPolicy Constructor
2 participants
@alzimmermsft @srnagar