modify the default value to avoid breaking changes of http client #26062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiliuTo
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
saragluna and
stliu
as code owners
ghost
added
the
saragluna
requested changes
Dec 20, 2021
Comment on lines
+73
to
+76
| AzureEventHubsProperties properties = context.getBean(AzureEventHubsProperties.class); | ||
| Integer maximumConnectionPoolSize = | ||
| properties.getProcessor().getCheckpointStore().getClient().getMaximumConnectionPoolSize(); | ||
| assertEquals(maximumConnectionPoolSize, 500); |
There was a problem hiding this comment.
I suggest we add a separate test case here.
yiliuTo
added
azure-spring-eventhubs
|
Close this pr for this has been fixed at the SDK side via #26083, and it will take effect after the version of 1.12.0 of azure-core-http-netty being released. |
saragluna
modified the milestones:
Spring Cloud Azure 4.0 GA,
Spring Cloud Azure 4.0 Beta3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the default value of maximumConnectionPoolSize as 500, which is to keep the same default behaviour with reactor netty client and avoid breaking changes with our previous versions.
Ref: https://projectreactor.io/docs/netty/snapshot/reference/index.html#_connection_pool_2