Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reactor-netty
uses different default values for maxConnections and pendingAcquireMaxCount when aHttpClient
instance is created with and without aConnectionProvider
.HttpClient.create()
uses 500 connections (called when HttpClientOptions is not set)HttpClient.create(ConnectionProvider)
uses maxAvailableProcessors * 2 (minimum of 16) (called when HttpClientOptions is set).pendingAcquireMaxCount
is 2x themaxConnections
if not explicitly set.This difference in defaults can lead to issues like this - #26027
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines