Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty default maxconnections #26083

Merged
merged 6 commits into from Dec 20, 2021
Merged

Conversation

srnagar
Copy link
Member

@srnagar srnagar commented Dec 17, 2021

Description

reactor-netty uses different default values for maxConnections and pendingAcquireMaxCount when a HttpClient instance is created with and without a ConnectionProvider.

HttpClient.create() uses 500 connections (called when HttpClientOptions is not set)
HttpClient.create(ConnectionProvider) uses maxAvailableProcessors * 2 (minimum of 16) (called when HttpClientOptions is set).

pendingAcquireMaxCount is 2x the maxConnections if not explicitly set.

This difference in defaults can lead to issues like this - #26027

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes. (but disabled due to a bug in reactor-netty)

Copy link
Member

@alzimmermsft alzimmermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, is this a bug in Reactor Netty or a design decision?

@srnagar srnagar enabled auto-merge (squash) December 20, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants