Add sslHandshakeTimeoutMinDuration in the RntbdTransportClient.Options #31298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
milismsft,
aayush3011 and
simorenoh
as code owners
ghost
added
the
| @@ -722,6 +724,39 @@ public void verifyRequestFailures( | |||
| } | |||
| } | |||
|
|
|||
| // TODO: add validations for other properties | |||
| @Test(groups = "unit") | |||
There was a problem hiding this comment.
I think a test case is missing where connect timeout is < default connect timeout
There was a problem hiding this comment.
added the missing test
But I disabled the "transportClientCustomizedOptionsTests" for now as had a hard time for forcing the class to be reloaded - @FabianMeiswinkel any suggestions here?
FabianMeiswinkel
approved these changes
Oct 6, 2022
|
API change check API changes are not detected in this pull request. |
xinlian12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the minimum value allowed for sslHandshake
And the final SslHandshakeTimeout = Math.max(connectionTimeout, sslHandshakeTimeoutMin)