Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the deprecated apis for spring cloud azure 5.0 #31543

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Oct 18, 2022

Fixes #31330
Upgrade the deprecated APIs of Spring and Azure SDKs.

@ghost ghost added the azure-spring All azure-spring related issues label Oct 18, 2022
@moarychan moarychan self-assigned this Oct 18, 2022
@moarychan moarychan added this to the 2022-11 milestone Oct 18, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 18, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-integration-azure-core
spring-cloud-azure-autoconfigure

@@ -48,6 +48,8 @@ public class DefaultMessageHandler extends AbstractMessageProducingHandler {
private final String destination;
private final SendOperation sendOperation;
private boolean sync = false;

@SuppressWarnings("deprecation")
private ListenableFutureCallback<Void> sendCallback;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdk/spring/CHANGELOG.md Outdated Show resolved Hide resolved
@@ -39,7 +38,7 @@ public Resource retrieveResource(URL url) throws IOException {
HttpHeaders headers = new HttpHeaders();
headers.setAccept(Arrays.asList(MediaType.APPLICATION_JSON, APPLICATION_JWK_SET_JSON));
ResponseEntity<String> response = getResponse(url, headers);
if (response.getStatusCodeValue() != HttpStatus.OK.value()) {
if (response.getStatusCode().isError()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it.

@moarychan moarychan merged commit db29c9a into Azure:feature/spring-boot-3 Oct 26, 2022
@moarychan
Copy link
Member Author

moarychan commented Oct 26, 2022

Also fixed the issue #31716 in Spring Cloud Azure 5.x

@moarychan moarychan deleted the moary/replace-deprecated-apis-for-spring-cloud-azure branch October 26, 2022 09:57
@fangjian0423 fangjian0423 changed the title Upgrade the deprecated apis for spring cloud azure 6.0 Upgrade the deprecated apis for spring cloud azure 5.0 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Replace all the Spring Boot 3 and Spring Cloud 2022.0.0 deprecated APIs
5 participants