Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress error report for CancellationException #32175

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

FabianMeiswinkel
Copy link
Member

Description

Recent reactor change resulted in excessive logging of CancellationException that is caused by reactor not cancelling Future from the Mono-wrapper. Annie has a fix candidate for it (see [PR#https://github.com//pull/31882]) - but it is a bigger change - so, we will not merge it into the Nov. release. This is a short-term workaroudn to avoid flooding the logs (esepcially in Spark where Cancellations are happening at the end of each query for a spark partition/epk-range)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@FabianMeiswinkel FabianMeiswinkel merged commit ac24429 into Azure:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants