Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Log Messages when Configuring Reactor Netty ConnectionProvider #32826

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Add Log Messages when Configuring Reactor Netty ConnectionProvider #32826

merged 3 commits into from
Jan 9, 2023

Conversation

alzimmermsft
Copy link
Member

Description

Adds log messages when there are modifications to Reactor Netty's connection pool configurations.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Jan 9, 2023
@ghost ghost added the Azure.Core azure-core label Jan 9, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@alzimmermsft alzimmermsft merged commit 432748c into Azure:main Jan 9, 2023
@alzimmermsft alzimmermsft deleted the AzNetty_AddLogMessageWhenConnectionProviderIsSet branch January 9, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billwert billwert billwert approved these changes

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alzimmermsft @azure-sdk @billwert