-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a separate module for spring-cloud-azure-native-reachability #33055
Add a separate module for spring-cloud-azure-native-reachability #33055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two improvements need to address:
- There should only be an entry for Spring readme files in the cspell.json
- To improve the
custom.security
configuration for Maven and Gradle, for right now the two are not in the same folder.
graalvmNative { | ||
binaries { | ||
main { | ||
buildArgs('-Djava.security.properties=' + file("src/main/resources/custom.security").absolutePath) | ||
} | ||
} | ||
} | ||
bootRun { | ||
systemProperty("java.security.properties", file("src/main/resources/custom.security").absolutePath) | ||
systemProperty('spring.aot.enabled', 'true') | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moarychan could you help verify the correctness of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, will test it later.
API change check APIView has identified API level changes in this PR and created following API reviews. |
Description
The Spring AOT support was removed in #32742 because we have yet to be ready to GA the AOT support. This PR will introduce another module, the
spring-cloud-azure-native-reachabitity
to host the support for Spring AOT. This module won't be GA in the feature because once we are ready for the Spring AOT support, these codes will be incorporated into each module.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines