Add a separate module for spring-cloud-azure-native-reachability #33055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
backwind1233,
chenrujun,
hui1110,
Netyyyy,
stliu,
yiliuTo,
moarychan and
fangjian0423
as code owners
ghost
added
the
moarychan
requested review from
alzimmermsft,
samvaity,
g2vinay and
JimSuplizio
as code owners
saragluna
commented
Jan 18, 2023
saragluna
commented
Jan 18, 2023
saragluna
commented
Jan 18, 2023
Comment on lines
+103
to
+113
| graalvmNative { | ||
| binaries { | ||
| main { | ||
| buildArgs('-Djava.security.properties=' + file("src/main/resources/custom.security").absolutePath) | ||
| } | ||
| } | ||
| } | ||
| bootRun { | ||
| systemProperty("java.security.properties", file("src/main/resources/custom.security").absolutePath) | ||
| systemProperty('spring.aot.enabled', 'true') | ||
| } |
There was a problem hiding this comment.
@moarychan could you help verify the correctness of this?
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Spring AOT support was removed in #32742 because we have yet to be ready to GA the AOT support. This PR will introduce another module, the
spring-cloud-azure-native-reachabitityto host the support for Spring AOT. This module won't be GA in the feature because once we are ready for the Spring AOT support, these codes will be incorporated into each module.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines