-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComsosDiagnosticsContext: Made system usage property bag #35405
Merged
FabianMeiswinkel
merged 13 commits into
Azure:main
from
FabianMeiswinkel:users/fabianm/SystemUsageApiRenames
Jun 9, 2023
Merged
ComsosDiagnosticsContext: Made system usage property bag #35405
FabianMeiswinkel
merged 13 commits into
Azure:main
from
FabianMeiswinkel:users/fabianm/SystemUsageApiRenames
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DB Spark connector Added option to override the MicroBatchPayloadSize in bytes from Spark connector to accommodate better efficiency when documents are large > 110KB
FabianMeiswinkel
requested review from
kushagraThapar,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
June 9, 2023 19:56
…to users/fabianm/SystemUsageApiRenames
lmolkova
approved these changes
Jun 9, 2023
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosDiagnosticsContext.java
Outdated
Show resolved
Hide resolved
...smos/src/main/java/com/azure/cosmos/implementation/CosmosDiagnosticsSystemUsageSnapshot.java
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
xinlian12
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ComsosDiagnosticsContext: Made system usage property bag
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines