-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limited max. number of threads possible to be used by BulkExecutor instances #38745
Merged
FabianMeiswinkel
merged 4 commits into
Azure:main
from
FabianMeiswinkel:users/fabianm/RejectedExecutionException
Feb 12, 2024
Merged
Limited max. number of threads possible to be used by BulkExecutor instances #38745
FabianMeiswinkel
merged 4 commits into
Azure:main
from
FabianMeiswinkel:users/fabianm/RejectedExecutionException
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
kushagraThapar,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
February 12, 2024 15:38
FabianMeiswinkel
changed the title
Limited max. number of threads possible to be used by BulkExecutor stances
Limited max. number of threads possible to be used by BulkExecutor instances
Feb 12, 2024
API change check API changes are not detected in this pull request. |
/azp run java - cosmos - tests |
/azp run java - cosmos - spark |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - spark |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a high number of concurrent BulkExecutor instances (concurrent calls to
Cosmos(Async)Container.executeBulkOperations
) is used, it is possible that they start causing exceptions with ajava.util.concurrent.RejectedExecutionException
- typical callstack see below.This is caused by each
BlukExecutor
instance using a ThreadPool (max. 1 thread) to ensure operations get flushed (send to the service in a micro batch in regular intervals - default 1 per second). This PR changes the logic to instead use one static bounded elastic ThreadPool - which will avoid the resource exhaustion when there are thousands ofBulkExecutor
instances used concurrently.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines