fewChangesAroundDiagnosticsHandler

[xinlian12]

Issues:
There have been reported application hanging caused due to the System.exit in diagnosticsProvider.

Changes:

• Only system.exit for error cases
• Suppress any exceptions when calling diagnosticsHandlers. Only log the error message
• Add System.err for error cases
• Even though by default we still call System.err for jvm error cases, but it can be disabled by setting the following system property or environment variable: COSMOS.DIAGNOSTICS_PROVIDER_SYSTEM_EXIT_ON_ERROR
• If customer has registered a mapper to convert error to exception(NOT RECOMMEND), the total mapper execution count will show up in CosmosDiagnostics:
  

"cosmos-rntbd-epoll-2-4" #164 daemon prio=5 os_prio=0 cpu=1651247.45ms elapsed=306164.59s tid=0x00007f8d9047b800 nid=0x7eb8 in Object.wait()  [0x00007f8cf9184000]
   java.lang.Thread.State: WAITING (on object monitor)
	at java.lang.Object.wait(java.base@11.0.18/Native Method)
	- waiting on <no object reference available>
	at java.lang.Thread.join(java.base@11.0.18/Thread.java:1300)
	- waiting to re-lock in wait() <0x000000070208acd8> (a java.lang.Thread)
	at java.lang.Thread.join(java.base@11.0.18/Thread.java:1375)
	at java.lang.ApplicationShutdownHooks.runHooks(java.base@11.0.18/ApplicationShutdownHooks.java:107)
	at java.lang.ApplicationShutdownHooks$1.run(java.base@11.0.18/ApplicationShutdownHooks.java:46)
	at java.lang.Shutdown.runHooks(java.base@11.0.18/Shutdown.java:130)
	at java.lang.Shutdown.exit(java.base@11.0.18/Shutdown.java:174)
	- locked <0x0000000702086da0> (a java.lang.Class for java.lang.Shutdown)
	at java.lang.Runtime.exit(java.base@11.0.18/Runtime.java:116)
	at java.lang.System.exit(java.base@11.0.18/System.java:1752)
 at com.azure.cosmos.implementation.DiagnosticsProvider.endSpan(DiagnosticsProvider.java:250)
	...
       ...
       ... 
	at java.util.concurrent.CompletableFuture.completeExceptionally(java.base@11.0.18/CompletableFuture.java:2088)
	at com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdRequestManager.messageReceived(RntbdRequestManager.java:1144)
	at com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdRequestManager.channelRead(RntbdRequestManager.java:214)

"SpringApplicationShutdownHook" #22 prio=5 os_prio=0 cpu=128.90ms elapsed=1643.40s tid=0x00007f8d9428e000 nid=0x6a14 in Object.wait()  [0x00007f8ce44be000]
   java.lang.Thread.State: WAITING (on object monitor)
	at java.lang.Object.wait(java.base@11.0.18/Native Method)
	- waiting on <no object reference available>
	at java.lang.Object.wait(java.base@11.0.18/Object.java:328)
	at io.netty.util.concurrent.DefaultPromise.awaitUninterruptibly(DefaultPromise.java:275)
	- waiting to re-lock in wait() <0x0000000755a9fe40> (a io.netty.util.concurrent.PromiseTask)
	at io.netty.util.concurrent.DefaultPromise.awaitUninterruptibly(DefaultPromise.java:35)
	at com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdClientChannelPool.close(RntbdClientChannelPool.java:540)
	at com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdServiceEndpoint.close(RntbdServiceEndpoint.java:366)
	at com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdServiceEndpoint$Provider.close(RntbdServiceEndpoint.java:732)
	at com.azure.cosmos.implementation.directconnectivity.RntbdTransportClient.close(RntbdTransportClient.java:201)
	at com.azure.cosmos.implementation.directconnectivity.StoreClientFactory.close(StoreClientFactory.java:73)
	at com.azure.cosmos.implementation.LifeCycleUtils.closeQuietly(LifeCycleUtils.java:16)
	at com.azure.cosmos.implementation.RxDocumentClientImpl.close(RxDocumentClientImpl.java:4540)
	at com.azure.cosmos.CosmosAsyncClient.close(CosmosAsyncClient.java:558)
	at org.springframework.beans.factory.support.DisposableBeanAdapter.destroy(DisposableBeanAdapter.java:239)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.destroyBean(DefaultSingletonBeanRegistry.java:587)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.destroySingleton(DefaultSingletonBeanRegistry.java:559)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.destroySingleton(DefaultListableBeanFactory.java:1161)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.destroySingletons(DefaultSingletonBeanRegistry.java:520)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.destroySingletons(DefaultListableBeanFactory.java:1154)
	at org.springframework.context.support.AbstractApplicationContext.destroyBeans(AbstractApplicationContext.java:1106)
	at org.springframework.context.support.AbstractApplicationContext.doClose(AbstractApplicationContext.java:1075)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.doClose(ServletWebServerApplicationContext.java:172)
	at org.springframework.context.support.AbstractApplicationContext.close(AbstractApplicationContext.java:1021)
	- locked <0x0000000701262548> (a java.lang.Object)
	at org.springframework.boot.SpringApplicationShutdownHook.closeAndWait(SpringApplicationShutdownHook.java:145)
	at org.springframework.boot.SpringApplicationShutdownHook$$Lambda$4052/0x0000000801678c40.accept(Unknown Source)
	at java.lang.Iterable.forEach(java.base@11.0.18/Iterable.java:75)
	at org.springframework.boot.SpringApplicationShutdownHook.run(SpringApplicationShutdownHook.java:114)
	at java.lang.Thread.run(java.base@11.0.18/Thread.java:829)

[azure-sdk]

API change check

API changes are not detected in this pull request.

[FabianMeiswinkel]

LGTM

[xinlian12]

/azp run java - cosmos - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[xinlian12]

/azp run java - cosmos - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).