Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport for release of azure-cosmos_4.45.3-hotfix #39184

Conversation

jeet1995
Copy link
Member

@jeet1995 jeet1995 commented Mar 12, 2024

Changes summary:

This along with removing System.exit() calls from ImplementationBridgeHelpers.

* few changes in diagnostics provider

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>

(cherry picked from commit b052394)
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jeet1995
Copy link
Member Author

/azp run java - cosmos - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeet1995
Copy link
Member Author

/azp run java - cosmos - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeet1995
Copy link
Member Author

Observations from the live tests pipeline:

  • clientTelemetryWithStageJunoEndpoint is failing - this has been fixed in a later PR - unrelated to this PR.
  • conflictCustomLWW - known flaky test.
  • readMany - had a known bug 4.45.x versions fixed in 4.47.0.
  • recordNewAddressesAfterSplit - passes locally.

Speculation related and client-telemetry related tests have been removed in future versions.

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeet1995 jeet1995 merged commit 2973004 into Azure:hotfix/jeet1995/azure-cosmos_4.45.3-hotfix Mar 18, 2024
54 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants