Issue #2934: Setup unit test coverage reports #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanGiles
requested changes
Jun 14, 2019
eng/testcoverage/pom.xml
Outdated
| <version>1.0.0-SNAPSHOT</version> | ||
|
|
||
| <name>Microsoft Azure client library for Application Configuration</name> | ||
| <description>This package contains the Microsoft Azure Application Configuration client library.</description> |
There was a problem hiding this comment.
Previous two lines are copy/paste fails.
pom.client.xml
Outdated
| @@ -630,6 +649,7 @@ | |||
| <modules> | |||
| <module>./eng/spotbugs-aggregate-report</module> | |||
| <module>./eng/code-quality-reports</module> | |||
| <module>./eng/testcoverage</module> | |||
There was a problem hiding this comment.
For naming consistency, can this be 'jacoco-test-coverage'
bsiegel
suggested changes
Jun 14, 2019
JonathanGiles
approved these changes
Jun 14, 2019
bsiegel
reviewed
Jun 14, 2019
bsiegel
reviewed
Jun 14, 2019
| @@ -201,7 +201,7 @@ jobs: | |||
| displayName: 'Run tests' | |||
| inputs: | |||
| mavenPomFile: $(pomFile) | |||
| options: '$(DefaultOptions) $(ProfileFlag)' | |||
| options: '$(DefaultOptions) $(ProfileFlag) -Dinclude-non-shipping-modules' | |||
There was a problem hiding this comment.
I'm not sure what this change does, will rely on @JonathanGiles insight here
bsiegel
reviewed
Jun 14, 2019
bsiegel
approved these changes
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to setup JaCoCo for reporting unit test coverage for all track 2 modules.
When this is released, unit test coverage reports should be available at the link below:
https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-java/staging/test-coverage/index.html