Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Job Router bugs #39495

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

williamzhao87
Copy link
Member

@williamzhao87 williamzhao87 commented Apr 1, 2024

Description

Fix null fields in RouterJob, RouterWorker, etc
Fix null value in RouterWorkerSelector
Fix etag missing in entities
Fix matching mode kind set to null
Fix queue not set in worker
Fix Job scheduling
Update tests

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@williamzhao87 williamzhao87 force-pushed the williamzhao/fix-java-bugs branch 2 times, most recently from 334fc3b to 3f43dd9 Compare April 2, 2024 16:14
@williamzhao87 williamzhao87 merged commit 478108f into release/job-router-1.13 Apr 2, 2024
18 checks passed
@williamzhao87 williamzhao87 deleted the williamzhao/fix-java-bugs branch April 2, 2024 16:45
williamzhao87 added a commit that referenced this pull request Apr 12, 2024
* Revert "[ACS JobRouter] Max concurrent offers on workers (#38664)"

This reverts commit 370d14d.

* Add HMAC Auth policy (#39451)

* Fix Job Router bugs (#39495)

* Fix Job Router bugs

* Build

* Add RevApi justification

* Fix Job Router Bugs 2 (#39514)

* Fix Job Router Bugs 2

* Fix RevApi

* Use custom serializer and deserializers for Job Router (#39568)

* Use custom serializer and deserializers for Job Router

* Checkstyle

* Add max concurrent offers

* Update tests, changelog, update methods

* Update versions

* Update test failure

* Bump version to 2.0.0-beta.1

* Update typespec & revapi

* Use enums for kind

* Add more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants