Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Job Router Bugs 2 #39514

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix Job Router Bugs 2 #39514

merged 2 commits into from
Apr 3, 2024

Conversation

williamzhao87
Copy link
Member

@williamzhao87 williamzhao87 commented Apr 2, 2024 •
edited

Description

Fixes following bugs:

  • Missing method createJobWithClassifcationPolicy and object CreateJobWithClassificationPolicyOptions
  • CreateClassificationPolicyOptions does not support omitting any of the three main rule/selectors (prioritizationRule, WorkerSelectors, queueSelectors) these values can not be null
  • Add Value to RouterWorkerSelector/RouterQueueSelector constructors, remove setter
  • Change return type of CreateJobWithResponse to RouterJob instead of BinaryData
  • Fix Kind properties for all polymorphic models

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@williamzhao87 williamzhao87 merged commit 0438a67 into release/job-router-1.13 Apr 3, 2024
18 checks passed
@williamzhao87 williamzhao87 deleted the williamzhao/fix-router-bugs-2 branch April 3, 2024 16:22
NathanJBennett
NathanJBennett approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@NathanJBennett NathanJBennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

williamzhao87 added a commit that referenced this pull request Apr 12, 2024
@williamzhao87
Job Router updates for 2.0 (#39667)
978f218 
* Revert "[ACS JobRouter] Max concurrent offers on workers (#38664)"

This reverts commit 370d14d.

* Add HMAC Auth policy (#39451)

* Fix Job Router bugs (#39495)

* Fix Job Router bugs

* Build

* Add RevApi justification

* Fix Job Router Bugs 2 (#39514)

* Fix Job Router Bugs 2

* Fix RevApi

* Use custom serializer and deserializers for Job Router (#39568)

* Use custom serializer and deserializers for Job Router

* Checkstyle

* Add max concurrent offers

* Update tests, changelog, update methods

* Update versions

* Update test failure

* Bump version to 2.0.0-beta.1

* Update typespec & revapi

* Use enums for kind

* Add more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bga-msft bga-msft bga-msft approved these changes

@NathanJBennett NathanJBennett NathanJBennett approved these changes

@mssfang mssfang Awaiting requested review from mssfang

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@williamzhao87 @bga-msft @NathanJBennett