fixChangingFeedModeCheckingForPkRangeVersion #40420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
|
API change check API changes are not detected in this pull request. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
approved these changes
May 31, 2024
|
Tested readAllItemsWithDetailMetricsWithExplicitPageSize locally |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When customer uses handleChanges (PkRange based lease), if lease store has been initialized, then starting the change feed processor will fail with the following exception:
java.lang.IllegalArgumentException: Illegal base64 character 22Root cause:
There has been a recent change to validate the change feed mode in the lease during changeFeed startup. When trying to validate the changeFeedMode in the lease, we are using ChangeFeedState.fromString() to parse the continuationToken, this method excepts the continuationToken to be in base64 format. However, for pkRange based lease, the continuationToken is only a long, that is when the above exception will be thrown.
Fix:
Remove the change feed mode checking if customer is on pkRange based lease, as only Incremental change feed mode is supported in the pkRange based lease.