Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4953 Adding rule to package info to be required #4976

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

vhvb1989
Copy link
Member

Adding as commented rule.

Issues fond that need to be fixed before turning on:

  • com/azure/storage/common/Utility.java
  • com/azure/storage/file/ShareClientBuilder.java

@vhvb1989
Copy link
Member Author

Issues found report

checkstyleIssuesReport.zip

@JonathanGiles
Copy link
Member

@alzimmermsft Can you get the two missing package-info.java files added, so that this rule can be enabled? Thanks!

Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending changes from Alan and others on the two storage package-info.java files.

@vhvb1989 vhvb1989 requested a review from srnagar August 13, 2019 22:45
@vhvb1989 vhvb1989 merged commit 73f9a0f into master Aug 13, 2019
@vhvb1989 vhvb1989 deleted the package-info-checkstyle-rule branch August 13, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants