Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHub management support #580

Merged

Conversation

sideshowcoder
Copy link

Add create, show, delete, index for event hubs.

  • eventhubs types (Result types, description type, info type)
  • Added needed actions to ServiceBusContract
  • Added lifecycle test for event hub (create, list, show, delete)

fixes #553

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @sideshowcoder, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@@ -0,0 +1,59 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this class? Seems to simply hold an instance of EventHubInfo and doesn't convey much information. Not to mention that a result should not be mutable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current structure of requests follows this pattern and I think it would be more confusing for one model to differ on this.

@sideshowcoder
Copy link
Author

I signed the CLA, also not sure how much this applies as I am a MS employee as well :)

Add create, show, delete, index for event hubs.

- eventhubs types (Result types, description type, info type)
- Added needed actions to `ServiceBusContract`
- Added lifecycle test for event hub (create, list, show, delete)

fixes Azure#553
@sideshowcoder sideshowcoder force-pushed the programmatically-create-event-hubs branch from ff98f8d to c787d49 Compare January 21, 2016 10:28
@sideshowcoder
Copy link
Author

My manager recieved the CLA but it has my name in his name field? This is a little confusing, any help?

@jianghaolu
Copy link
Contributor

@azuresdkci add to whitelist

If you work for Microsoft, I will ignore the CLA thing.

Is service bus team aware of this change? SDK team manages the repository but we don't own the service bus features. Please make sure they are aware of this and then we can proceed.

@jianghaolu
Copy link
Contributor

@azuresdkci add to whitelist

@jianghaolu
Copy link
Contributor

@azuresdkci test this please

@sideshowcoder
Copy link
Author

@djrosanova is aware of this change, so I guess that should be fine? Maybe he can comment on this?

jianghaolu added a commit that referenced this pull request Mar 2, 2016
@jianghaolu jianghaolu merged commit a07edcd into Azure:master Mar 2, 2016
jianghaolu added a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Apr 5, 2017
…te-event-hubs

EventHub management support
jianghaolu added a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Apr 5, 2017
…te-event-hubs

EventHub management support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventHub support
5 participants