-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventHub management support #580
EventHub management support #580
Conversation
Can one of the admins verify this patch? |
Hi @sideshowcoder, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
@@ -0,0 +1,59 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this class? Seems to simply hold an instance of EventHubInfo
and doesn't convey much information. Not to mention that a result should not be mutable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current structure of requests follows this pattern and I think it would be more confusing for one model to differ on this.
I signed the CLA, also not sure how much this applies as I am a MS employee as well :) |
Add create, show, delete, index for event hubs. - eventhubs types (Result types, description type, info type) - Added needed actions to `ServiceBusContract` - Added lifecycle test for event hub (create, list, show, delete) fixes Azure#553
ff98f8d
to
c787d49
Compare
My manager recieved the CLA but it has my name in his name field? This is a little confusing, any help? |
@azuresdkci add to whitelist If you work for Microsoft, I will ignore the CLA thing. Is service bus team aware of this change? SDK team manages the repository but we don't own the service bus features. Please make sure they are aware of this and then we can proceed. |
@azuresdkci add to whitelist |
@azuresdkci test this please |
@djrosanova is aware of this change, so I guess that should be fine? Maybe he can comment on this? |
…ent-hubs EventHub management support
…te-event-hubs EventHub management support
…te-event-hubs EventHub management support
Add create, show, delete, index for event hubs.
ServiceBusContract
fixes #553