-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventHub management support #580
Merged
jianghaolu
merged 1 commit into
Azure:master
from
sideshowcoder:programmatically-create-event-hubs
Mar 2, 2016
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
162 changes: 115 additions & 47 deletions
162
...ebus/src/main/java/com/microsoft/windowsazure/services/servicebus/ServiceBusContract.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
...main/java/com/microsoft/windowsazure/services/servicebus/models/CreateEventHubResult.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/** | ||
* | ||
* Copyright (c) Microsoft and contributors. All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
package com.microsoft.windowsazure.services.servicebus.models; | ||
|
||
/** | ||
* Represents the result of a <code>createTopic</code> operation. | ||
*/ | ||
public class CreateEventHubResult { | ||
|
||
private EventHubInfo value; | ||
|
||
/** | ||
* Creates an instance of the <code>CreateEventHubResult</code> class. | ||
* | ||
* @param value | ||
* A {@link EventHubInfo} object assigned as the value of the | ||
* result. | ||
*/ | ||
public CreateEventHubResult(EventHubInfo value) { | ||
this.setValue(value); | ||
} | ||
|
||
/** | ||
* Specfies the value of the result. | ||
* | ||
* @param value | ||
* A {@link EventHubInfo} object assigned as the value of the | ||
* result. | ||
*/ | ||
public void setValue(EventHubInfo value) { | ||
this.value = value; | ||
} | ||
|
||
/** | ||
* Returns the value of the result. | ||
* | ||
* @return A {@link EventHubInfo} object that represents the value of the | ||
* result. | ||
*/ | ||
public EventHubInfo getValue() { | ||
return value; | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this class? Seems to simply hold an instance of
EventHubInfo
and doesn't convey much information. Not to mention that a result should not be mutable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current structure of requests follows this pattern and I think it would be more confusing for one model to differ on this.