Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event-hubs][service-bus] re-export RetryMode enum from core-amqp #13166

Closed
chradek opened this issue Jan 12, 2021 · 2 comments · Fixed by #13484
Closed

[event-hubs][service-bus] re-export RetryMode enum from core-amqp #13166

chradek opened this issue Jan 12, 2021 · 2 comments · Fixed by #13484
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus

Comments

@chradek
Copy link
Contributor

chradek commented Jan 12, 2021

The clients from @azure/event-hubs and @azure/service-bus accept RetryOptions as defined in @azure/core-amqp.

One of the fields in RetryOptions, mode, is an enum called RetryMode that allows users to choose a fixed or exponential retry strategy.

Currently RetryMode is not re-exported by the @azure/event-hubs and @azure/service-bus packages, so to specify a mode, a user would need to import the RetryMode enum from @azure/core-amqp.

Instead, we should re-export RetryMode so users don't need to depend directly on our core-amqp package.

Related to #12587

@chradek chradek added Client This issue points to a problem in the data-plane of the library. Service Bus Event Hubs labels Jan 12, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] February milestone Jan 12, 2021
@snuffykl
Copy link

snuffykl commented Jan 29, 2021

@chradek Curious is there a way for us(client) to specify this retry for @azure/service-bus package as a SB Topic sender when calling function sendbatch ?

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
@HarshaNalluru
Copy link
Member

@snuffykl
You can specify the retryOptions at the client level such as below.

    new ServiceBusClient("<connection-string>", {
      retryOptions: { mode: RetryMode.Exponential, maxRetries: 5, timeoutInMs: 3000 }
    });

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants