[Service Bus] (Minor) Internal rename

[HarshaNalluru]

As suggested at #13374 (comment),

_batchingReceiverLite.close can be better named as _batchingReceiverLite.cancel or _batchingReceiverLite.terminate since they seem to make more sense than close.

More code pointers:

• Set up environment and run rush build
• Open the sdk/servicebus/service-bus folder in your editor/IDE, search for the relevant method at src/core/batchingReceiver.ts

[ShrillShrestha]

Hi there, I am a beginner and searching for some issues to learn and contribute. I am not fully knowledgeable about the project, but this seems a good issue to work on and learn. If anyone can guide me with the issue, I might be able to resolve it. Does this issue only needs renaming to be solved?

[HarshaNalluru]

Yes, this issue is meant to rename and update with the new name wherever it is referenced.
BatchingReceiverLite class which is not part of the exported API and is used internally, has the close method - which we want to rename.

Please follow the links posted in the description for the instructions. Let me know if you're stuck at any step, I'll be able to help you through it.

[ShrillShrestha]

Sure @HarshaNalluru, I will try to work on it. If I have any questions, I will let you know.

[ShrillShrestha]

@HarshaNalluru, so I changed:

azure-sdk-for-js/sdk/servicebus/service-bus/src/core/batchingReceiver.ts

Line 311 in ee90255

close(connectionError?: Error | AmqpError) {

to: terminate(connectionError?: Error | AmqpError) {.
The close method was referenced at:

azure-sdk-for-js/sdk/servicebus/service-bus/src/core/batchingReceiver.ts

Line 96 in ee90255

this._batchingReceiverLite.close(connectionError);

which I changed to: this._batchingReceiverLite.terminate(connectionError); .
I tried to find if the method was referenced at other places, but couldn't find it at any other place. So, should I search for anywhere specific? And are the changes made above correct?

[ShrillShrestha]

Also, how do I run a test to know if I broke anything? I tried doing rushx test as mentioned in the contribution guide, but it seems like there is no test command.
This is the error message I get:
Error: The command "test" is not defined in the package.json file for this project.
and mentions the available commands are "build", "check:everything", "latest", "local", "preinstall".

[HarshaNalluru]

but it seems like there is no test command.

Based on the error message you posted, you might be running the command from the root of the repository.
You need to navigate to the project's folder before running the commands, sdk/servicebus/service-bus level in this case.
You can see the available commands that you can run with rushx at sdk/servicebus/service-bus/package.json.

The test command runs the live tests which would require Azure resources.
unit-test command would run the tests that don't need the Azure resources.

I tried to find if the method was referenced at other places, but couldn't find it at any other place. So, should I search for anywhere specific? And are the changes made above correct?

There could be other places.
Try build and build:test commands as they would point out the errors from the compilation.

You can open a PR with what you think is right, the team will review and request changes as needed.

[HarshaNalluru]

Done with #13419