Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication]Set the sender as undefined instead of empty when sender id not populated #13689

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[Communication]Set the sender as undefined instead of empty when sender id not populated #13689

merged 1 commit into from
Feb 9, 2021

Conversation

LuChen-Microsoft
Copy link
Member

@LuChen-Microsoft LuChen-Microsoft commented Feb 9, 2021 •
edited
Loading

The current behavior for the SDK if message sender ID is not populated from service, the SDK will return an empty sender property. This PR is to change that to undefined instead of empty in that situation.

@ghost ghost added the Communication label Feb 9, 2021
@LuChen-Microsoft LuChen-Microsoft changed the title Make the sender as undefined instead of empty when sender id not populated Set the sender as undefined instead of empty when sender id not populated Feb 9, 2021
@LuChen-Microsoft LuChen-Microsoft changed the title Set the sender as undefined instead of empty when sender id not populated [Communication]Set the sender as undefined instead of empty when sender id not populated Feb 9, 2021
juancamilor
juancamilor approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@juancamilor juancamilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also update E2E live test to fail if the senderid is not the expected instead of silently pass.
We can do that as a follow up PR

@juancamilor juancamilor merged commit 8fd4f0e into master Feb 9, 2021
@juancamilor juancamilor deleted the luc/sender-undefined branch February 9, 2021 16:00
@LuChen-Microsoft
Copy link
Member Author

LuChen-Microsoft commented Feb 9, 2021 •
edited
Loading

Lets also update E2E live test to fail if the senderid is not the expected instead of silently pass.
We can do that as a follow up PR

This PR already include the test change @juancamilor

juancamilor
juancamilor reviewed Feb 9, 2021
View reviewed changes
sdk/communication/communication-chat/test/chatThreadClient.mocked.spec.ts
assert.deepEqual(responseMessage, expectedMessage);
assert.equal(responseUser?.communicationUserId, expectedId);
assert.deepEqual(repsonseContents, expectedContents);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: repsonseContents => responseContents

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 29, 2021
@xaliciayang @ayeletshpigelman
@strehan1993 @kukislav @athreya-geetha
CodeGen from PR 13689 in Azure/azure-rest-api-specs
22b27dd 
Dev sql microsoft.sql 2020 11 01 preview minor change (Azure#13689)

* Adds base for updating Microsoft.Sql from version preview/2020-08-01-preview to version 2020-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add updated 2020-11-01-preview versions of LongTermRetenionBackups.json and Databases.json (Azure#12146)

* add updated databases.json swagger

* update readme with new package

* v4 -> v5

* add missing chunk in readme

* add correct swaggeR

* add examples

* add correct examplese

* remove unreferenced examples

* update swagger and examples. add 2020-11 pure package

* Fix reference to 2020-08-01 reference to ElasticPools.json

* update Databases.json name

* update examples

* remove nonexistant swagger

* fixed reference capitals in readme

* update package composite and fix ref to ManagedInstances.jsON

* make backupstorageredundancy settings consistent

* add requestedBackupStorageRedundancy to properties object in example

* add LTR swagger and examples

* add LTR Policies swagger and examples

* make v5 match v4

* add updated Databses.json

* merge conflicts in LTR Policies swagger'

* take out comments in readme

* taking ImportExport.json out from 2020-11 package

* remove duplicate 2020-11 tag in readme

* modify Databases_legacy.json to exclude ImportExport-related APIs

* add servers.json for IE APIS and remove unused databases examples

* fix model & prettier errors; add missing server example

* add missing servers examples

* fix example to exclude property from server obj

* change RecommendedActions definitoins

* change tag to composite v4

* Add missing properties for api version 2020-02-02-preview of securityAlertPolicies (Azure#13117)

* Add missing properties for api version 2020-02-02-preview

* fix checks

* fix according to prettier check

* Add the change to version 2020-08-01-preview and version 2020-11-01-preview

* remove changes in package-lock

* Add new line at the end of file

* update version 2020-11-01-preview

* Update the ref to system data in serverdevopsaudit

* add missing point

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* fix the validation errors (Azure#13325)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* Address Private Endpoint validation issues in V3, V2 and V1 SDK tags (Azure#13404)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* Identity/Key/external Admin API (Azure#13411)

* Add examples for sql mi remove maintenance configuration (Azure#13390)

* Add missing specs 2020 11 01 (Azure#13488)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* add missing specs in 2020-11-01-preview

* update the validation errors

* update systemData and sync with global common/v1/types.json

* update legacy to match the latest database specs

* remove RestorableDroppedManagedInstances due to it should be internal

* Updated database extensions (Azure#13584)

Co-authored-by: Geetha Athreya <geathrey@microsoft.com>

Co-authored-by: xaliciayang <59986952+xaliciayang@users.noreply.github.com>
Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com>
Co-authored-by: strehan1993 <70013163+strehan1993@users.noreply.github.com>
Co-authored-by: Ivan Kulezic <72797230+kukislav@users.noreply.github.com>
Co-authored-by: Geetha Athreya <43223869+athreya-geetha@users.noreply.github.com>
Co-authored-by: Geetha Athreya <geathrey@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancamilor juancamilor juancamilor approved these changes

@DominikMe DominikMe Awaiting requested review from DominikMe

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit

@0rland0Wats0n 0rland0Wats0n Awaiting requested review from 0rland0Wats0n

@bterlson bterlson Awaiting requested review from bterlson

@chradek chradek Awaiting requested review from chradek

@xirzec xirzec Awaiting requested review from xirzec

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LuChen-Microsoft @juancamilor