New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify behavior of clientId and resourceId #20461
Comments
Hello @billwert ! Does this mean that we get to pick how other languages should approach this? Our approach at the moment is to throw if both I think this is a fair compromise. What do you think? |
Hello! This issue is largely a reminder that we all need to come together before we release. I missed standup yesterday but plan to talk about it a bit next week. Throwing in this case also seems reasonable to me. I mostly want to ensure we all do a similar thing so the conceptual experience is the same. |
If the correct approach is to throw if both are provided, we currently do that. I believe this is the correct approach based on the conversations we’ve had on our weekly meetings. Should we close this issue? |
Ok we chatted on teams and this issue is done. I’ll close it. |
[2022-04-01-preview] Add New Api-version for Microsoft.ApiManagement (Azure#20399) * Adds base for updating Microsoft.ApiManagement from version preview/2021-12-01-preview to version 2022-04-01-preview * Updates readme * Updates API version in new specs and examples * APIM Auth Servers (Azure#19234) * APIM Auth Servers * adding x-ms-identifiers * removing some weird, invisible special char * formatting * oAuth2AuthenticationSettings moved to AuthSettings * Formatting Co-authored-by: Milan Zolota <mizolota@microsoft.com> * API Management Authorization Endpoints (Azure#19615) * Add blockchain to latest profile * Add additional types * add authorizations definitions * authorizations operations * add examples * update readme * fix examples * fix linter delete errors * address CI validation errors * prettier fix * update to 2022-04 * fix readme * Update specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimauthorizationproviders.json Co-authored-by: Sean Kim <seaki@microsoft.com> * update versions * Apply suggestions from code review Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Annaji Sharma Ganti <anganti@microsoft.com> Co-authored-by: Annaji Sharma Ganti <42851022+annaji-msft@users.noreply.github.com> * Move Long running Create Operation from Location based to Azure-AsyncOperation Header (Azure#19733) * azure-asyncOperation * prettier * fix(apim): Add missing 'metrics' property to diagnostics contract in 2022-04-01-preview (Azure#20317) * apim /PUT apis import add translateRequiredQueryParameters (Azure#20333) * [2022-04-01-preview] Replace resource with proxyresource and TrackedResource (Azure#20461) * replace resource with proxyresource * revert to proxyresource * Add type object to authorization definitions (Azure#20631) Authorization definitions were missing "type": "object", and this change adds that key/value pair * Add type object to policy fragment definition (Azure#20585) * APIM Open ID Connect providers (Azure#20622) * APIM Open ID Connect providers * added new proeprties for update * prettier * [APIM] Add Nat Gateway (Azure#19990) * Update apimdeployment.json * Create ApiManagementCreateServiceWithNatGatewayEnabled.json * fix typo in file * Change Nat Gateway property to enum * modify type of natgateway state * update property name * add example reference * small fix in example * rename to outboundPublicIPAddresses Co-authored-by: Samir Solanki <samirsolanki@outlook.com> * [2022-04-01-preview] MIgrate2Stv2 API (Azure#20504) * migrate2stv2 * updated to post * 202 and location * add body to 202 * remove body from 202 Co-authored-by: Vatsa Patel <vatsapatel@microsoft.com> Co-authored-by: Samir Solanki <samirsolanki@outlook.com> Co-authored-by: vatsapatel@microsoft.colm <vatsapatel@microsoft.colm> * Address Authorizations MissingTypeObject errors (Azure#20919) * Add forgotten If-Match header (Azure#20920) * Add forgotten If-Match header `If-Match` header for the `DeleteAuthorizationAccessPolicy.json file` was forgotten. This change adds the wildcard character for the `If-Match` header for that file. * Update ApiManagementDeleteAuthorization.json * Use common types for specs and count as readonly (Azure#21023) * common types * count readonly * Sasolank/more review comments (Azure#21025) * XML * proxy to gateway * Update Authorizations Spec (Azure#21027) * Update definitions.json Update wording for PostGetLoginLink endpoint description * Update apimauthorizationproviders.json Add 201 response to all Authorization PUT requests * Updated examples and fixed formatting There was a formatting issue within apimauthorizationproviders.json, and the Authorization examples needed to be updated with the new 201 responses for creating/updating Authorization entities. * Add long-running-operation key/value Added x-ms-long-running-operation: true to Authorization PUT requests * Remove long-running-operations * readonly revert (Azure#21050) * Set SchemaContract.Document as required. (Azure#20110) * Updated documentation of the SchemaContract. Server use to return code 500 in case SchemaContract.Document is null. That issue was fixed in the APIM and server will return proper response code. * Fix AzureApiValidation * update field with properties * revert remaining readonly on collection (Azure#21051) * Change to camel casing for "accesspolicies" (Azure#21070) * Change to camel casing for "accesspolicies" * More camel casing updates for access policies * list example fixed (Azure#21089) * fix definition (Azure#21110) * upgrade to v3 for common types (Azure#21109) * upgrade to v3 * Space * revert to v2 proxyResource Co-authored-by: Milan Zolota <Hardell@users.noreply.github.com> Co-authored-by: Milan Zolota <mizolota@microsoft.com> Co-authored-by: Sean D Kim <seandkim14@gmail.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Annaji Sharma Ganti <anganti@microsoft.com> Co-authored-by: Annaji Sharma Ganti <42851022+annaji-msft@users.noreply.github.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Korolev Dmitry <deagle.gross@gmail.com> Co-authored-by: Logan Zipkes <44794089+LFZ96@users.noreply.github.com> Co-authored-by: Rafał Mielowski <mielex@gmail.com> Co-authored-by: malincrist <92857141+malincrist@users.noreply.github.com> Co-authored-by: GuanchenIntern <109827715+GuanchenIntern@users.noreply.github.com> Co-authored-by: VatsaPatel <vatsapatel13@gmail.com> Co-authored-by: Vatsa Patel <vatsapatel@microsoft.com> Co-authored-by: vatsapatel@microsoft.colm <vatsapatel@microsoft.colm> Co-authored-by: Maxim Agapov <103097563+agapovm@users.noreply.github.com>
Recently we added the ability to set both a
clientId
andresourceId
for user assigned managed identity lookups. This exposes the problem that if an environment setsAZURE_CLIENT_ID
while the deployed code setsresourceId
we'll hit an exception.The work item here is two parts:
The text was updated successfully, but these errors were encountered: