-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] react-native issues/regressions #30065
Labels
Comments
jeremymeng
added
Client
This issue points to a problem in the data-plane of the library.
Azure.Core
labels
Jun 14, 2024
originated from #29980 |
3 tasks
mpodwysocki
added a commit
that referenced
this issue
Jun 17, 2024
### Packages impacted by this PR - @azure/logger ### Issues associated with this PR - #30065 ### Describe the problem that is addressed by this PR Adds logging support through the browser implementation of the logger logic. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
This was referenced Jun 17, 2024
mpodwysocki
added a commit
that referenced
this issue
Jun 18, 2024
### Packages impacted by this PR - @azure/core-rest-pipeline - @typespec/ts-http-runtime ### Issues associated with this PR - #30065 ### Describe the problem that is addressed by this PR Adds web crypto APIs for React-Native calls. Requires the consumer to polyfill the Web Crypto APIs in order for these modules to work. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
mpodwysocki
added a commit
that referenced
this issue
Jun 18, 2024
### Packages impacted by this PR - @azure/core-rest-pipeline - @typespec/ts-http-runtime ### Issues associated with this PR - #30065 ### Describe the problem that is addressed by this PR Adds more support for user agents for browser and fixes React-Native implementation to import "react-native". ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
3 tasks
mpodwysocki
added a commit
that referenced
this issue
Jun 18, 2024
### Packages impacted by this PR - @azure/core-rest-pipeline - @typespec/ts-http-runtime ### Issues associated with this PR - #30065 ### Describe the problem that is addressed by this PR Updates the following: - Adds Proxy Policy for react-native to throw since it is not supported, same for browser. - Adds React-Native support for concat streams same as browser support - Adds React-Native support for inspect same as browser support ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Can you tell what the expected date is when this fixing gets into the release ? |
@tonylucgi the planned date for the July release is 7/11/2024 |
jeremymeng
added a commit
that referenced
this issue
Jul 12, 2024
jeremymeng
added a commit
that referenced
this issue
Jul 17, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
With this option from React-Native, our
react-native
conditional exports are respected, but issues also surface. Previously most of these were mapped to their browser version for react-native.await import
causing react-native error compiling JS code because it putsawait
in an non-async context.import from
node:` modules, we probably could make a react-native version using same code from browser version.azure-sdk-for-js/sdk/core/logger/src/log.ts
Line 4 in 3afccc6
crypto
import { createHash, createHmac } from "crypto";
with some resolver configuration?Buffer
, browser version should work too for react-native.core-amqp has similar problems too: util/
The text was updated successfully, but these errors were encountered: