Acataldi/10779 fix schema registry lint errors #12011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
customer-reported
|
Thank you for your contribution abc516! We will review the pull request and get back to you soon. |
ramya-rao-a
reviewed
Oct 26, 2020
| @@ -45,7 +45,7 @@ const testGroup = "azsdk_js_test_group"; | |||
| const testSchemaIds = [ | |||
| "{773E17BE-793E-40B0-98F1-0A6EA3C11895}", | |||
| "{DC7EF290-CDB1-4245-8EE8-3DD52965866E}" | |||
| ].map((x) => x.replace(/[\{\-\}]/g, "")); | |||
| ].map((x) => x.replace(/[{\-}]/g, "")); | |||
There was a problem hiding this comment.
@abc516 Can you share which linting rule failure is this change fixing?
@nguerrera, Do you recall what exactly are we trying to replace here and why?
There was a problem hiding this comment.
@ramya-rao-a @nguerrera this fixes this rule: https://eslint.org/docs/rules/no-useless-escape .
I believe it just subs out the '{', '-', and '}' chars in the guid strings with blank spaces. Note the test below from https://regexr.com , using the new expression :
There was a problem hiding this comment.
Yes, that's what it does and this is fine. 😄
nguerrera
approved these changes
Oct 26, 2020
ramya-rao-a
approved these changes
Oct 26, 2020
|
Thanks @abc516! |
|
Thanks, @abc516 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10779