[core-lro] No polling allowed when the operation is in a terminal state #24159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check API changes are not detected in this pull request. |
This was referenced Dec 8, 2022
MaryGao
reviewed
Dec 16, 2022
MaryGao
reviewed
Dec 16, 2022
There was a problem hiding this comment.
Could you use the version to test if it could pass the autores.typescript ci - Azure/autorest.typescript#1586?
bterlson
approved these changes
Dec 19, 2022
I verified that integration tests for both RLC and HLC pass with this version. |
deyaaeldeen
added a commit
that referenced
this pull request
Jan 11, 2023
This release contains the work in #24159 and is needed for the code generator tests to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/core-lro
Issues associated with this PR
Failures in Azure/autorest.typescript#1586
Describe the problem that is addressed by this PR
poll()always sends the polling request as long as the operation has a location to poll from. However, once the operation is in a terminal state, there is no need to send the polling request.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Sending the useless polling request is not the end of the world and won't affect the state of the poller. I don't feel strongly about the change but it is nice to not do unjustified extra work.
Are there test cases added in this PR? (If not, why?)
Yes.
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists